Fix FCKeditor browser detection to work with Firefox 17

[Gervase Markham]

Hi CKeditor team,

Various bits of browser detection that FCKeditor does, in at least 2 places, break because the Firefox 17 User Agent has changed a bit. The Gecko part changed from:

Gecko/20100101 (this number had been frozen for 3 years)

to

Gecko/17.0

The main detector in fckbrowserinfo.js works, but there are other bits of the code which sniff browser versions which are broken. I don't have the details exactly to hand but here are two of them: ​http://dev.ckeditor.com/browser/FCKeditor/trunk/fckeditor_php5.php#L55 ​http://dev.ckeditor.com/browser/FCKeditor/trunk/fckeditor.asp#L202

Would you guys consider doing a small bugfix release of the software to update it, or have you decided never to do any more?

I note from your Wikipedia page that there was a security bug in FCKeditor a while ago. I suspect many people are still using vulnerable versions (we've certainly had problem reports from older versions). If you were to make this fix, we could then publicise it, which would encourage people to update and make them safer at the same time.

Gerv (Mozilla)

[Gervase Markham]

(I can't see how to get updated by email when this ticket changes... Please can someone ping me at gerv at mozilla dot org? Thanks :-)

Gerv

[Sebastian]

Users are also reporting IE10 having the same problem. A fix has been proposed here: ​http://kartiksehgal.wordpress.com/2012/11/16/fckeditor-bug-fix-for-ie10/

[Rick]

I removed the check altogether if it's gecko in order to get around the FF17 issue. Chances that someone has a FF browser older than 2003 is slim.

[Gervase Markham]

Sounds great - thank you :-)

Gerv

[Wiktor Walc]

Fixed with [7665], [7666], [7668] (download ​FCKeditor 2.6.9)