Opened 7 years ago

Closed 7 years ago

#9757 closed Bug (fixed)

Obsolete parameter in event.implementOn calls

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0.1
Component: General Version: 4.0.1
Keywords: Cc:

Description

Function is defined as follows:

CKEDITOR.event.implementOn = function( targetObject ) {
...
}

but there's a number of executions with non-existing parameter (true) in our code:

./core/command.js:212:CKEDITOR.event.implementOn( CKEDITOR.command.prototype, true );
./core/editor_basic.js:35:	CKEDITOR.event.implementOn( CKEDITOR.editor.prototype, true );
./plugins/dialog/plugin.js:1498:	CKEDITOR.event.implementOn( CKEDITOR.dialog.prototype, true );

Change History (5)

comment:1 Changed 7 years ago by Jakub Ś

Status: newconfirmed

comment:2 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:3 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

t/9757@cksource

comment:4 Changed 7 years ago by Piotrek Koszuliński

Status: reviewreview_passed

comment:5 Changed 7 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Masterised git:d4c048f

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy