Opened 6 years ago

Closed 6 years ago

#9772 closed Bug (fixed)

Custom buttons added to dialog are smaller

Reported by: Alfonso Martínez de Lizarrondo Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0.2
Component: UI : Dialogs Version: 4.0
Keywords: Cc:

Description

When a custom button is added to the footer of a dialog

		buttons : [ {
				type : 'button',
				id : 'myReset',
				label : 'Reset'
		}, CKEDITOR.dialog.okButton, CKEDITOR.dialog.cancelButton ],

it's smaller than the default Ok and Cancel buttons.

Attachments (2)

dialog.html (1.9 KB) - added by Alfonso Martínez de Lizarrondo 6 years ago.
Modified sample to test the problem
button.png (5.7 KB) - added by Alfonso Martínez de Lizarrondo 6 years ago.
screenshot

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Alfonso Martínez de Lizarrondo

Attachment: dialog.html added

Modified sample to test the problem

Changed 6 years ago by Alfonso Martínez de Lizarrondo

Attachment: button.png added

screenshot

comment:1 Changed 6 years ago by Alfonso Martínez de Lizarrondo

This happens both in Kama and Moono. 3.x worked fine

comment:2 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.0.2
Status: newconfirmed

comment:3 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:4 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

Created a new branch t/9772@cksource with a fix.

  • Left additional footer buttons bold.
  • Reviewer should carefully check whether other buttons located in regular dialog tabs are also affected.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:6 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Fixed issue with a commit git:9284c371cf4.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy