Failing command test after switching off selectionChange's errorProof flag

[Piotrek Koszuliński]

1. Switch off errorProof flag on selectionChange event (see selection.js).
2. One test is faling on: ​http://ckeditor4.t/dt/core/command/command.html

Hint: it doesn't fail when ran alone - ​http://ckeditor4.t/dt/core/command/command.html?name=test-command-states-in-detailssummary

[Olek Nowodziński]

Created branch with fix in t/9848@tests-v4.

There are two reasons for this issue:

1. editorBot.setHtmlWithSelection() is noisy and makes selectionChange fire multiple times before the right HTML is set and the right selection is done. This distracts command's refresh callback and yields bad asserts since it calls refresh on selectionChange if contextSensitive: true. This is a bad testing method for delicate, selection-dependent features.
2. Three tests use the same editor and, once the command is defined in one test with a refresh callback containing assertions, those assertions are checked in successive tests as well yielding errors.

In fact, the problem wasn't "test command states in details>summary" (first one) but "test "contextSensitive" property" (last one). I changed the way the command is tested and eventually removed it so it's refresh() isn't executed anymore in the future.

[Frederico Caldeira Knabben]

Before considering the proposed workaround, I would ask to investigate if it is possible instead to fix selectionChange, to avoid "selectionChange fire multiple times before the right HTML is set".

[Olek Nowodziński]

Pushed new solution to t/9848b@tests-v4.

• Fixed 1. from comment:3 by avoiding additional selectionChange because of editor.focus() in CKTESTER.tools.setHtmlWithSelection in IE>8 and other browsers. This change seems to not interact with other tests.

• Ported some part of solution for 2. from previous branch.

This combo is much simpler and cleaner than t/9848@tests-v4.

[Frederico Caldeira Knabben]

I'm assuming this fix is not needed for IE<9.

[Olek Nowodziński]

Added info regarding IE versions. Fixed with 89814fa@tests-v4.