Opened 6 years ago

Closed 6 years ago

#9887 closed Bug (fixed)

Disable magicline when editor.readOnly

Reported by: Olek Nowodziński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0.2
Component: Core : Read-only Version: 4.0 Beta
Keywords: magicline Cc:

Description

It's possible to use magicline in read-only editor. This is incorrect.

Change History (5)

comment:1 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 4.0.1 (GitHub - master)4.0 Beta
  1. Go to readonly.html sample
  2. Switch to source and paste the following code
    <hr />
    <hr />
    <table border="1" cellpadding="1" cellspacing="1" style="width: 500px;">
    	<tbody>
    		<tr>
    			<td>&nbsp;</td>
    			<td>&nbsp;</td>
    		</tr>
    		<tr>
    			<td>&nbsp;</td>
    			<td>&nbsp;</td>
    		</tr>
    		<tr>
    			<td>&nbsp;</td>
    			<td>&nbsp;</td>
    		</tr>
    	</tbody>
    </table>
    
  3. Switch to WYSIWYG and hover over editor contents. Magic line shows up
  4. Press read-only button and hover over contents again. Magic line still shows up.

Problem can be reproduced from CKE 4 beta.

comment:2 Changed 6 years ago by Olek Nowodziński

Status: confirmedassigned

comment:3 Changed 6 years ago by Olek Nowodziński

Status: assignedreview

Created t/9887@cksource branch with 1LOC solution.

comment:4 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

I would say 1/3LOC solution :D

comment:5 in reply to:  4 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Replying to fredck:

I would say 1/3LOC solution :D

Git works on integers! ;)

Fixed issue with git:f41c432e170d86f99.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy