Ticket #5767 (closed Bug: fixed)
List plugin: appendBogus should only be called for empty list items
| Reported by: | arne | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.4.2 |
| Component: | Core : Lists | Version: | 3.0 |
| Keywords: | Firefox Safari | Cc: |
Description
When building the list in the
createList function
the method
listItem.appendBogus()
is called for all but IE browsers. As the comment states this is done to render the list item at full height. But this is only necessary if the list item (or the elements inside the list item) are empty. If there is content in the elements the content will give height to the list item.
Suggestion: Only add bogus elements when the list item(and its elements) are empty.
Attachments
Change History
comment:2 in reply to: ↑ 1 Changed 3 years ago by arne
Replying to garry.yao:
You see any side effects bring by our default behavior?
No, I have not observed any behavioral/rendering side effects.
comment:3 Changed 3 years ago by fredck
- Status changed from new to closed
- Resolution set to wontfix
The current code is made that way to make things simple, and has no impact on the editor usage or performance.
We may think about change it if we face an issue related to it. Please feel free to reopen the ticket in that case.
comment:4 Changed 3 years ago by garry.yao
- Status changed from closed to reopened
- Component changed from General to Core : Lists
- Version set to 3.0
- Milestone set to CKEditor 3.4
- Keywords Confirmed Firefox Safari added
- Resolution wontfix deleted
Unfortunately #5445 is an evidence for this problem.
You see any side effects bring by our default behavior?