Ticket #5767 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

List plugin: appendBogus should only be called for empty list items

Reported by: arne Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.4.2
Component: Core : Lists Version: 3.0
Keywords: Firefox Safari Cc:

Description

When building the list in the

createList function

the method

listItem.appendBogus()

is called for all but IE browsers. As the comment states this is done to render the list item at full height. But this is only necessary if the list item (or the elements inside the list item) are empty. If there is content in the elements the content will give height to the list item.

Suggestion: Only add bogus elements when the list item(and its elements) are empty.

Attachments

5767.patch (2.1 KB) - added by garry.yao 4 years ago.

Change History

comment:1 follow-up: ↓ 2 Changed 4 years ago by garry.yao

You see any side effects bring by our default behavior?

comment:2 in reply to: ↑ 1 Changed 4 years ago by arne

Replying to garry.yao:

You see any side effects bring by our default behavior?

No, I have not observed any behavioral/rendering side effects.

comment:3 Changed 4 years ago by fredck

  • Status changed from new to closed
  • Resolution set to wontfix

The current code is made that way to make things simple, and has no impact on the editor usage or performance.

We may think about change it if we face an issue related to it. Please feel free to reopen the ticket in that case.

Changed 4 years ago by garry.yao

comment:4 Changed 4 years ago by garry.yao

  • Status changed from closed to reopened
  • Component changed from General to Core : Lists
  • Version set to 3.0
  • Milestone set to CKEditor 3.4
  • Keywords Confirmed Firefox Safari added
  • Resolution wontfix deleted

Unfortunately #5445 is an evidence for this problem.

comment:5 Changed 4 years ago by garry.yao

  • Keywords Review? added

comment:6 Changed 4 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from reopened to new

comment:7 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.4 to CKEditor 3.5

comment:8 Changed 4 years ago by Saare

Supposed to be fixed by #6133.

comment:9 Changed 4 years ago by Saare

  • Keywords Safari added; Safari? removed
  • Status changed from review to closed
  • Resolution set to fixed

Fixed by #6133.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy