[FF] Click on "body" in elements path selects only on first block element

[Piotrek Koszuliński]

TC1:

1. Open replacebyclass sample.
2. Without focusing editor, click 'body' in elements path.
3. Only header and image were selected.

TC2:

1. Write two paragraphs.
2. Switch to source and back to wysiwyg.
3. Without focusing editor, click 'body' in elements path.
4. Only first paragraphs was selected.

Reproduced on FF, couldn't on Chrome, haven't checked the rest.

[Frederico Caldeira Knabben]

Introduced with ​git:a9d4df7.

[Frederico Caldeira Knabben]

It looks like the problem is that we're having two selection attempts happening at the same time when the editor gets focused. Firefox is buggy and is not able to handle this properly, making a random selection out of it.

I've proposed a fix on t/10119@cksource. It doesn't change much the logic of the code. It just demonstrates that the focus logic is very delicate and even the order of things matter. In any case, we're not able to do much about all this, until browsers will not be strong and stable about selection.

[Piotrek Koszuliński]

OK, I haven't found any regressions and issue seems to be fixed. It's good to understand that this patch just targets more precisely patch for #9507.

PS. Is it possible to write test for this issue?

[Piotrek Koszuliński]

Fixed on master with ​git:a2136ce.