Opened 7 years ago

Closed 7 years ago

#9507 closed Bug (fixed)

[FF] Focus on editor focused for the first time set selection before editable position

Reported by: Piotrek Koszuliński Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.0.2
Component: Core : Focus Version: 4.0
Keywords: IBM Cc: satya_minnekanti@…

Description

  1. Open editor with content: <p>xxx</p>
  2. Without focusing it press bold or insert link.
  • Expected: <p><b>^</b>xxx</p> or link inserted before "xxx".
  • Actual: Bold and link are created before first paragraph and not autoparagraphed.

Change History (17)

comment:1 Changed 7 years ago by Piotrek Koszuliński

Component: GeneralCore : Focus

comment:2 Changed 7 years ago by Piotrek Koszuliński

Summary: [FF] Focus on previously unfocused editor set selection before editable position[FF] Focus on editor focused for the first time set selection before editable position

comment:3 Changed 7 years ago by Garry Yao

Milestone: CKEditor 4.0CKEditor 4.0.1
Status: newconfirmed

Suppose to be fixed by #9499, but this issue shall not block the release.

comment:4 Changed 7 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added
Keywords: IBM added

adding myself to cc

comment:5 Changed 7 years ago by Garry Yao

As #9499 is closed as a regression fix, opened t/9507 on dev and tests, for a solution to this, the patches was originally proposed on #9499.

comment:6 Changed 7 years ago by Garry Yao

Owner: set to Garry Yao
Status: confirmedreview

comment:7 Changed 7 years ago by Piotrek Koszuliński

Pushed git:5cafbc9 (branch moved from previous-cksource remote).

comment:8 Changed 7 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.0.1CKEditor 4.0.2
Status: reviewreview_failed
Uncaught TypeError: Cannot call method 'apply' of undefined in editable.js:88

comment:9 Changed 7 years ago by Piotrek Koszuliński

Owner: changed from Garry Yao to Piotrek Koszuliński
Status: review_failedassigned

Pushed git:41c0e7f for issue mentioned in comment:8.

This issue still needs careful manual testing and a couple of unit tests.

comment:10 Changed 7 years ago by Olek Nowodziński

Owner: changed from Piotrek Koszuliński to Olek Nowodziński

comment:11 Changed 7 years ago by Olek Nowodziński

Owner: Olek Nowodziński deleted
Status: assignednew

comment:12 Changed 7 years ago by Jakub Ś

Status: newconfirmed

Additional TC.

  1. Stat editor with <p>xxx</p>
  2. Click inside paragraph <p>x^xx</p>
  3. Click few times on page outside of editor so that it loses focus.
  4. Click bold button

Result: Bold starts where cursor was last in editor. In this case this is <p>x<strong></strong>xx</p>

comment:13 Changed 7 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedassigned

comment:14 Changed 7 years ago by Olek Nowodziński

Rebased t/9507@cksource to latest master.

comment:15 Changed 7 years ago by Olek Nowodziński

Status: assignedreview

As:

  1. t/9507@cksource is for FF only
  2. t/9507@cksource also passes on master@tests-v4 (all browsers)
  3. t/9507@tests-v4 is very chaotic, massive and obscure. I'm unable to check what and why has been changed.

I propose the simple case in t/9507b@tests-v4 as a fair test to verify the correctness of the solution, which also discards all the changes from t/9507@tests-v4.

comment:16 Changed 7 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:17 Changed 7 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Fixed in git:d904beb99e1.

Merged tests in 94a4c57@tests-v4.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy