Opened 10 years ago
Closed 10 years ago
#9507 closed Bug (fixed)
[FF] Focus on editor focused for the first time set selection before editable position
| Reported by: | Piotrek Koszuliński | Owned by: | Olek Nowodziński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.0.2 |
| Component: | Core : Focus | Version: | 4.0 |
| Keywords: | IBM | Cc: | satya_minnekanti@… |
Description
- Open editor with content:
<p>xxx</p> - Without focusing it press bold or insert link.
- Expected:
<p><b>^</b>xxx</p>or link inserted before "xxx". - Actual: Bold and link are created before first paragraph and not autoparagraphed.
Change History (17)
comment:1 Changed 10 years ago by
| Component: | General → Core : Focus |
|---|
comment:2 Changed 10 years ago by
| Summary: | [FF] Focus on previously unfocused editor set selection before editable position → [FF] Focus on editor focused for the first time set selection before editable position |
|---|
comment:3 Changed 10 years ago by
| Milestone: | CKEditor 4.0 → CKEditor 4.0.1 |
|---|---|
| Status: | new → confirmed |
comment:4 Changed 10 years ago by
| Cc: | satya_minnekanti@… added |
|---|---|
| Keywords: | IBM added |
adding myself to cc
comment:5 Changed 10 years ago by
comment:6 Changed 10 years ago by
| Owner: | set to Garry Yao |
|---|---|
| Status: | confirmed → review |
comment:8 Changed 10 years ago by
| Milestone: | CKEditor 4.0.1 → CKEditor 4.0.2 |
|---|---|
| Status: | review → review_failed |
Uncaught TypeError: Cannot call method 'apply' of undefined in editable.js:88
comment:9 Changed 10 years ago by
| Owner: | changed from Garry Yao to Piotrek Koszuliński |
|---|---|
| Status: | review_failed → assigned |
Pushed git:41c0e7f for issue mentioned in comment:8.
This issue still needs careful manual testing and a couple of unit tests.
comment:10 Changed 10 years ago by
| Owner: | changed from Piotrek Koszuliński to Olek Nowodziński |
|---|
comment:11 Changed 10 years ago by
| Owner: | Olek Nowodziński deleted |
|---|---|
| Status: | assigned → new |
comment:12 Changed 10 years ago by
| Status: | new → confirmed |
|---|
Additional TC.
- Stat editor with
<p>xxx</p> - Click inside paragraph
<p>x^xx</p> - Click few times on page outside of editor so that it loses focus.
- Click bold button
Result: Bold starts where cursor was last in editor. In this case this is <p>x<strong></strong>xx</p>
comment:13 Changed 10 years ago by
| Owner: | set to Olek Nowodziński |
|---|---|
| Status: | confirmed → assigned |
comment:15 Changed 10 years ago by
| Status: | assigned → review |
|---|
As:
- t/9507@cksource is for FF only
- t/9507@cksource also passes on master@tests-v4 (all browsers)
- t/9507@tests-v4 is very chaotic, massive and obscure. I'm unable to check what and why has been changed.
I propose the simple case in t/9507b@tests-v4 as a fair test to verify the correctness of the solution, which also discards all the changes from t/9507@tests-v4.
comment:16 Changed 10 years ago by
| Status: | review → review_passed |
|---|
comment:17 Changed 10 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed in git:d904beb99e1.
Merged tests in 94a4c57@tests-v4.
Note: See
TracTickets for help on using
tickets.
Suppose to be fixed by #9499, but this issue shall not block the release.