Opened 12 years ago
Closed 11 years ago
#10430 closed Bug (fixed)
Unresolved dependence of image plugin if forms plugin
Reported by: | Karen Ananiev | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3 |
Component: | General | Version: | 4.0 |
Keywords: | Cc: |
Description
forms plugin uses "lang.image.titleButton", there is js error if image plugin is removed.
Change History (13)
comment:1 Changed 12 years ago by
Status: | new → pending |
---|---|
Version: | 4.1.1 |
comment:2 Changed 12 years ago by
I've used the source code (dev version) from github and removed image plugin from plugins list.
If you use removePlugins and use release version with included image plugin I guess you'll unable to reproduce.
comment:3 Changed 12 years ago by
Status: | pending → confirmed |
---|---|
Version: | → 4.0 |
Confirmed.
To reproduce go to builder, select full version and remove image plugin from list. Next download release, put it on server and try to open replacebycode sample in browser.
Error will be thrown and editor won't show up.
comment:6 Changed 12 years ago by
Keywords: | Discussion added |
---|
We have two simple option to follow here:
- Mark image plugin dependency on forms.
- Do not enable the image button if the image plugin is not available (I mean, not even register the command, button, etc.)
I would go for "2", assuming that image button is not the most important feature provided by the forms plugin. Still we would need this documented somewhere (maybe in the repository itself), to help people understanding this dependency trick.
comment:7 Changed 11 years ago by
Milestone: | → CKEditor 4.3 |
---|
comment:9 Changed 11 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:11 Changed 11 years ago by
If image
plugin is not available then imagebutton
will not be shown.
comment:12 Changed 11 years ago by
Keywords: | Discussion removed |
---|---|
Status: | review → review_passed |
I have tried using below code:
Next I have tried using form plugin and image button plugin but no error was logged.
@karena what is the proper way to reproduce this and what have I missed?