Opened 11 years ago
Closed 11 years ago
#10843 closed Bug (fixed)
MathJax widget tests
Reported by: | Piotr Jasiun | Owned by: | Piotr Jasiun |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 4.3 |
Component: | General | Version: | 4.3 Beta |
Keywords: | Cc: |
Description (last modified by )
Add missing tests to MathJax plugin:
- tests for: inline editor
- tests for: undo/redo
- tests for: absolute path and preview plugin
- tests for:
if ( el.children.length > 1 || el.children[ 0 ].type != CKEDITOR.NODE_TEXT )
Change History (17)
comment:1 Changed 11 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 11 years ago by
Owner: | set to Piotr Jasiun |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 11 years ago by
comment:4 Changed 11 years ago by
Description: | modified (diff) |
---|---|
Summary: | MathJax widget - missing tests → MathJax widget tests |
comment:5 Changed 11 years ago by
Status: | assigned → review |
---|
Most of the tests were rewritten. Now part of them works on frame wrapper mock, without real mathJax lib what is much faster. I ran these tests in all browser on dev and release but this should be done again during review (especially in IE). Everything in t/10937 branch.
comment:6 Changed 11 years ago by
Status: | review → assigned |
---|
comment:7 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
- git:95bd2fe
- tests:b802386
comment:8 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
Reopen ticked because of IE9 problems.
comment:9 Changed 11 years ago by
Status: | reopened → review |
---|
Changes in t/10843b and t/10843b tests.
comment:10 Changed 11 years ago by
Status: | review → review_failed |
---|
We understood that there may be better ways to solve this problem. Basically, the "mathJaxUpdateDone" event should be fired by the iframes, which are very unstable, but go a standard CKEditor object, which can be either "editor" or CKEDITOR.
comment:12 Changed 11 years ago by
Status: | review → review_passed |
---|
comment:13 Changed 11 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Closed:
- git:a2d9130
- tests:387f06c
I also added some jsDuck tags to mathjax plugin to mark some properties as local.
comment:14 Changed 11 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
I found that FF also behave differently with and without cache so these tests need some more improvements.
comment:15 Changed 11 years ago by
Status: | reopened → review |
---|
Changes in t/10843c test branch. Now tests works on FF without cache.
I also ignored test for loading indicator on IE8, bacause IE8 sometimes load everything synchronously, without indicator.
comment:16 Changed 11 years ago by
Status: | review → review_passed |
---|
As a part of this ticket I will also work on: