Opened 6 years ago

Closed 6 years ago

#10951 closed Bug (fixed)

A11y improvements on panels

Reported by: Frederico Caldeira Knabben Owned by: Frederico Caldeira Knabben
Priority: Normal Milestone: CKEditor 4.2.2
Component: Accessibility Version: 4.2.2
Keywords: IBM Cc: Damian, Teresa Monahan, Irina, satya_minnekanti@…

Description

This ticket is the result of research done for #10361, #10705, #10706 and #10707.

Changes will be proposed with the following results:

  • Normalize the aria attributes use on panels.
  • Stabilize the focus on panels when opened.

It touches rich-combos, menu-buttons and color buttons.

Change History (5)

comment:1 Changed 6 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: newreview

Pushed t/10951@cksource.

@tmonahan, can you please give it a try and confirm that it closes all these tickets?

comment:2 Changed 6 years ago by Satya Minnekanti

Cc: satya_minnekanti@… added
Keywords: IBM added

comment:3 Changed 6 years ago by Piotrek Koszuliński

Status: reviewreview_failed

I clicked through all combos and panels on FF, Chrome and IE9 and they work like a charm. Focus and selection are not lost at any point. All this is ok also when using keyboard to navigate.

However, R- because Chrome again started scrolling viewport when opening dropdowns.

comment:4 Changed 6 years ago by Piotrek Koszuliński

Status: review_failedreview_passed

I pushed a fix for the scrolling issue on Chrome. Branch was rebased. Since during my previous review I found only this issue I'm R+ing the branch now.

comment:5 Changed 6 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: review_passedclosed

Fixed with git:ec71357.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy