Opened 6 years ago

Closed 6 years ago

#10963 closed Bug (fixed)

JAWS issue with keyboard shortcut for magicline

Reported by: Satya Minnekanti Owned by: Olek Nowodziński
Priority: Normal Milestone: CKEditor 4.2.3
Component: General Version: 4.0.1
Keywords: IBM Cc: Teresa Monahan, Irina

Description

To reproduce the defect:

  1. Open nightly ck editor sample http://nightly.ckeditor.com/13-10-08-13-06/full/samples/ajax.html
  1. Click on Create Editor button.
  1. Insert 2 tables next to each other with default values.

  1. Keep cursor in first cell in first table.

  1. Press Ctrl + Shift + [ to insert a empty paragraph before the table

Issue: Nothing happens and JAWS reads Setting Region Top left corner

  1. Keep cursor in any cell in the last row of first table
  1. Press Ctrl + Shift + ] to insert a empty paragraph after first table or in-between two tables

Issue: JAWS reads Setting Region Bottom Right corner and a dialog comes with a title saying Create Frame or Prompt with 2 options Frame Create & Prompt Create

It works fine with out JAWS.

we have tested this with JAWS 14.0.6005 & Firefox 24

This issue is happening because "Ctrl + Shift + [" and "Ctrl + Shift + ]" are JAWS key combos documented in "Additional Notes on Keystrokes for Accessing the JAWS Utilities" in JAWS Help.

We should provide another unused key combo to perform Magicline function.

Change History (13)

comment:1 Changed 6 years ago by Olek Nowodziński

cc

comment:2 Changed 6 years ago by Jakub Ś

Status: newconfirmed
Version: 4.0.1

Below are notes from documentation:

Set Frame Top Left (CTRL+SHIFT+LEFT BRACKET) This command sets the top left corner for a frame based on the location of the JAWS or Invisible Cursor. If the bottom right corner of the frame has already been set, this command also brings up Frame Manager so the frame can be named and other Properties can be set.

Set Frame Bottom Right (CTRL+SHIFT+RIGHT BRACKET) This command sets the bottom right corner for a frame based on the location of the JAWS or Invisible Cursor. If the top left corner of the frame has already been set, this command also brings up Frame Manager so the frame can be named and other Properties can be set.

Problem can be reproduced from CKEditor 4.0.1 (when key shortcut was introduced)

comment:3 Changed 6 years ago by Teresa Monahan

The existing keystroke for magicline also does not work well for different keyboard layouts as the required key combination is sometimes not possible. For example, on the french keyboard you have to use Ctrl+Alt+5 to get the [ character and Ctrl+Alt+( for ]. Therefore it is not possible to use Ctrl+Shift+[ or Ctrl+Shift+]. Shortcut keys should therefore not rely on characters like [ and ] which require modifier keys on some keyboard layouts.

comment:4 Changed 6 years ago by Teresa Monahan

This is a high priority accessibility issue. Can you please plan a fix for this for the upcoming 4.2.3 milestone?

comment:5 Changed 6 years ago by Jakub Ś

I believe so. Please note however that we have changed this shortcut once already. Although this is easy to do we need to make some research for shortcut that isn't used anywhere and this may take some time.

Have you got any suggestions for such shortcut perhaps?
We could always go with 8 key shortcut - these aren't used ;)

I will forward this to my supervisor.

comment:6 Changed 6 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 4.2.3

comment:7 Changed 6 years ago by Frederico Caldeira Knabben

In fact, it would be nice to have a proposal for this, to avoid us having to change this again later.

comment:8 in reply to:  7 Changed 6 years ago by Teresa Monahan

Replying to fredck:

In fact, it would be nice to have a proposal for this, to avoid us having to change this again later.

We are looking into options for this but as you know it can be difficult to find shortcuts that are not already reserved. Currently we are exploring the possibility of using Ctrl+Shift+Up Arrow and Ctrl+Shift+Down Arrow, however for some reason JAWS does not read these keystrokes when invoked by the user. We are investigating why this might be. I will keep this ticket updated with our findings. Please let us know if you find keystrokes that would work for this in the meantime. Thanks, Teresa

comment:9 Changed 6 years ago by Marek Lewandowski

My suggestion goes for CTRL+SHIFT+9 and CTRL+SHIFT+0, this hotkey is not used by JAWS and is not popular in general so should do just fine.

comment:10 Changed 6 years ago by Teresa Monahan

CTRL+SHIFT+9 and CTRL+SHIFT+0 are used in Opera to open a links and windows menu respectively. As far as we can see CTRL+SHIFT+3 and CTRL+SHIFT+4 aren't reserved by browsers though and they work well with JAWS so this would be our suggestion.

comment:11 Changed 6 years ago by Olek Nowodziński

Owner: set to Olek Nowodziński
Status: confirmedreview

Created branch t/10963 that changes keystrokes to CTRL+SHIFT+3 and CTRL+SHIFT+4. They seem fine and not reserved in Linux, Windows (7) and OSX.

comment:12 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:13 Changed 6 years ago by Olek Nowodziński

Resolution: fixed
Status: review_passedclosed

Merged changes into master git:6f379b2.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy