Pagebreak loses contenteditable=false when pasting

[Piotrek Koszuliński]

It's lost, because it's not part of pagebreak's ACF rules. It could be added by dataFilter rule, but the style checks do not pass on internal form of pagebreak (no display:none style).

BTW. Regexp patterns are compiled every time div is filtered - they should be cached.

[Olek Nowodziński]

Solution in ​t/11133 (+ corresponding test branch).

Still I'm not quite convinced whether ​such a weak condition is enough to distinguish pagebreaks from regular divs while pasting.

TODO: Pagebreak should definitely be a widget.

[Piotrek Koszuliński]

There's no such thing as element.classes. It's a leftover from ACF. Use element.hasClass.

And yes - pagebreak should be a widget.

[Olek Nowodziński]

Replying to Reinmar:

There's no such thing as element.classes. It's a leftover from ACF. Use element.hasClass.

That's true, element.hasClass is the proper one. But it was more than that: since I checked element#classes for cke_pagebreak which was stripped out by ACF, the condition was also logically invalid. The correct check is

if ( element.attributes[ 'data-cke-display-name' ] )
    ...

[Piotrek Koszuliński]

Hm... this checks something totally different. This attribute carries information for elements path and can be used by various features. So this condition will give false positives.

[Olek Nowodziński]

It turned out that data-cke-pagebreak survives filtering and it's enough to tell pagebreak from other elements.

I also unified the way of setting the attributes of the "internal form" because I found it quite inconsistent and misleading. At the moment both pagebreak command and dataFilter rule use the same set of attributes generated by attributesSet which finally makes them totally coherent.

[Piotrek Koszuliński]

I pushed two commits to dev and tests. Solution is clean so it's good. Internal form is marked with a data-cke-pagebreak attribute and all data-cke-* attrs are allowed by ACF on input and are stripped by default data processor on output.

[Olek Nowodziński]

​git:77ab1b8 (dev) and 00a8345 (tests) landed in master.