Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#11244 closed Bug (fixed)

WidgetRepository#checkWidgets should fire checkWidgets event, not the other way

Reported by: Piotrek Koszuliński Owned by: Piotrek Koszuliński
Priority: Normal Milestone: CKEditor 4.3.1
Component: UI : Widgets Version: 4.3
Keywords: Cc:

Description

Currently it's recommended to fire widgetsRepository#checkWidgets which then triggers widgetsRepository#checkWidget method. It's confusing. More natural will be if method will fire an event and the default listener will execute checkWidgets' current action.

Change History (4)

comment:1 Changed 6 years ago by Piotrek Koszuliński

Owner: set to Piotrek Koszuliński
Status: newassigned

comment:2 Changed 6 years ago by Piotrek Koszuliński

Milestone: CKEditor 4.3.1
Status: assignedreview

Pushed t/11244 on dev and tests.

comment:3 Changed 6 years ago by Frederico Caldeira Knabben

Status: reviewreview_passed

comment:4 Changed 6 years ago by Piotrek Koszuliński

Resolution: fixed
Status: review_passedclosed

Fixed on master with git:35c31bc on dev and c9c5f40 on tests.

(corrected Git commit number for future reference - Anna)

Last edited 6 years ago by Anna Tomanek (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy