Opened 11 years ago
Closed 11 years ago
#11536 closed New Feature (fixed)
Create htmlDecode - complementary function to htmlEncode.
| Reported by: | Marek Lewandowski | Owned by: | Marek Lewandowski |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.4.0 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description (last modified by )
We're missing htmlDecode funciton in CKEDITOR.tools because we have:
htmlEncodeAttr - which has its complementary function htmlDecodeAttr
htmlEncode - which does not have htmlDecode
It make senese to implement such function.
We may consider to do it in conjuction with t/11536, since it will touch the same thing.
Related issues:
#11480 (currently it has implemented private implementation decodeHtml, so it should reuse tools version)
#11442
Change History (6)
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 11 years ago by
| Milestone: | → CKEditor 4.4 |
|---|---|
| Status: | new → confirmed |
comment:3 Changed 11 years ago by
| Owner: | set to Marek Lewandowski |
|---|---|
| Status: | confirmed → assigned |
comment:4 Changed 11 years ago by
| Status: | assigned → review |
|---|
comment:5 Changed 11 years ago by
| Status: | review → review_passed |
|---|
Please enhance test so it checks if 'g' flag was used in regexps. I found myself forgetting about it :D.
PS. It's better to make code style fixes at the beginning of branch, not at the end.
comment:6 Changed 11 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with git:da5e23cada2a at dev and 4246343793c57 at tests.
Note: See
TracTickets for help on using
tickets.
Pushed to t/11536 at dev and t/11536 at tests.