Opened 5 years ago

Closed 5 years ago

#11804 closed Bug (wontfix)

Making changes in Document Properties plugin does not reflect in history

Reported by: Artur Delura Owned by:
Priority: Normal Milestone:
Component: Core : Undo & Redo Version:
Keywords: Cc:

Description

When we change for example background color of document using document plugin, change in not saved in history, so we can't undo our changes.

Change History (1)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Keywords: document properties removed
Resolution: wontfix
Status: newclosed

Interesting bug. And impossible to fix at that moment or most likely - never. The reason is that undo manager records snapshots from body innerHTML. All the information set by docprops dialog are kept outside body or directly in the body tag. Theoretically we could record entire document's contents, but it's not recoverable - we cannot replace entire document with new one on undo/redo. So it would be very time consuming and code bloating to fix this issue. Therefore, since it wasn't reported by user, but during our internal testing phase, I'm closing it as won't fix.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy