Opened 5 years ago

Last modified 5 years ago

#12187 confirmed Bug

[Safari] Link's keystroke does not work

Reported by: Piotrek Koszuliński Owned by:
Priority: Normal Milestone:
Component: Core : Keystrokes Version: 3.0
Keywords: Safari Mac Cc:

Description

CMD+L always moves focus to Safari's URL bar, so it's impossible to create a link using keystroke.

Linking is often available under CMD+K. Maybe we can set both keystrokes?

Change History (3)

comment:1 Changed 5 years ago by Piotrek Koszuliński

Similar issue: #7505.

comment:2 Changed 5 years ago by Jakub Ś

Keywords: Mac added
Status: newconfirmed
Version: 3.0

This one looks like an easy fix:

var editor = CKEDITOR.replace( 'editor1', {			
	keystrokes : [  
		[ CKEDITOR.env.mac ? CKEDITOR.CTRL + CKEDITOR.SHIFT + 76 : CKEDITOR.CTRL + 76, 'link' ]    // Ctrl+Shift+L
	]
});

If we need to make it more detailed (to work only with Safari on Mac because Safari Win works) we can specify CKEDITOR.env.mac && CKEDITOR.env.safari

comment:3 Changed 5 years ago by Piotrek Koszuliński

I'm not sure whether it should be CTRL+SHIFT+L or CTRL+K, but the goal is to have both keystrokes (CTRL+L plus a safe one). Otherwise, users may be confused.

The above code does an odd thing because it adds one keystoke on Mac, but does nothing on other OSes. And of course the fix needs to be implemented in the link plugin.

Last edited 5 years ago by Piotrek Koszuliński (previous) (diff)
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy