Opened 9 years ago
Last modified 9 years ago
#12621 closed Bug
Can't remove Bold/Italic/Underline in empty line. — at Version 5
Reported by: | Jakub Ś | Owned by: | |
---|---|---|---|
Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 4.4.6 |
Component: | Core : Styles | Version: | 4.4.5 |
Keywords: | Blink Webkit Support | Cc: |
Description (last modified by )
This is happening mainly in Mac but some variation can be observed in Windows.
- Open replacebycode sample
- Put cursor at the end of first paragraph
July 21 at 02:56 UTC.^
and press enter. - Press Command+I or Ctrl+I
- Press Command+I or Ctrl+I again and type few letters.
Results: On Mac it is impossible to remove simple style. On Windows button is still highlighted, elements path shows 'em' but when you start typing you get normal text.
Problem can be reproduced in Blink and Webkit browsers from CKEditor 4.4.5.
This issue causes #12631.
Change History (5)
comment:1 Changed 9 years ago by
Status: | new → confirmed |
---|
comment:3 Changed 9 years ago by
It might look like a regression, but actually it's not. It's an older bug in the styles system (I might have reported it some time ago).
Nope, I haven't reported it.
comment:4 Changed 9 years ago by
Component: | General → Core : Styles |
---|
comment:5 Changed 9 years ago by
Description: | modified (diff) |
---|
It might look like a regression, but actually it's not. It's an older bug in the styles system (I might have reported it some time ago).
On 4.4.4 (and earlier versions), when you do that TC, there is an empty inline element left after you press the style keystroke for the 2nd time -
<p><strong></strong><br></p>
. It should be removed by the styles system when removing the style, but it's not.In 4.4.5 in #12423 we changed a behaviour of a method important for the styles and selection systems (so it's hard to say what it could affect). And I think that this change might actually be good, because it aligned the method behaviour on Webkit/Blink to Firefox. And on Firefox this problems isn't reproducible. This may mean that there's some other part of code wrong on Chrome/Blink (e.g. the code that affects the getStartElement() method).
Anyway, if we fix the issue in the styles system, then this issue (reported here) won't be reproducible. However, the
getStartElement()
behaviour must be checked too.