Opened 9 years ago
Closed 9 years ago
#13316 closed Task (fixed)
CKEDITOR.env.isCompatible should be a blacklist rather than a whiletlist
| Reported by: | Piotrek Koszuliński | Owned by: | Piotrek Koszuliński |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.5.0 |
| Component: | General | Version: | |
| Keywords: | Cc: |
Description
The reason is pretty simple – we know on what browsers CKEditor does not work (IE7-), but we do not know on what browsers it works and will work in the future. So given the problems with browsers recognition it will be much safer to have a blacklist.
Change History (12)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
| Status: | new → confirmed |
|---|
comment:3 Changed 9 years ago by
A big fat yes from me, more and more people are turning away from CKEditor since it "does not work on mobile" even though it may actually work quite all right with minor glitches, it's just disabled on purpose.
comment:4 Changed 9 years ago by
+1 from me although I have some mixed feelings about enabling it on browsers like Konqueror that we don't test.
comment:5 follow-up: 7 Changed 9 years ago by
I have some mixed feelings about enabling it on browsers like Konqueror that we don't test.
I had too. But the truth is:
- How do we recognise Konqueror?
- Why do we assume that CKEditor does not work there?
- How many people does it concern?
comment:7 Changed 9 years ago by
Replying to Reinmar:
I have some mixed feelings about enabling it on browsers like Konqueror that we don't test.
I had too. But the truth is:
- How do we recognise Konqueror?
- Why do we assume that CKEditor does not work there?
- How many people does it concern?
Yep, the list of advantages is much bigger than disadvantages. Adding my comment here just so that anyone was aware that we took it into consideration.
comment:8 Changed 9 years ago by
| Owner: | set to Piotrek Koszuliński |
|---|---|
| Status: | confirmed → assigned |
comment:9 Changed 9 years ago by
Pushed branch:t/13316, but I think that we'll need to discuss what we place here - http://docs.ckeditor.com/#!/guide/dev_browsers
comment:10 Changed 9 years ago by
| Status: | assigned → review |
|---|
We decided to completely rewrite http://docs.ckeditor.com/#!/guide/dev_browsers and that will be held in another ticket. For now, let's review the dev changes.
Pushed branch:t/13316.
To the reviewer: Please make sure that the new test passes on the Edge.
comment:11 Changed 9 years ago by
| Status: | review → review_passed |
|---|
comment:12 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Merged into major in git:384147f.
The most important issue that this change will fix is the fact that on many Android devices CKEditor does not work on Chrome if that browser is configured to be seen as a mobile one.