Opened 3 years ago

Closed 3 years ago

#13782 closed Bug (fixed)

CKEDITOR.warn/error logs are not clear

Reported by: Piotrek Koszuliński Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.5
Component: General Version: 4.5.4
Keywords: Cc:

Description

This is what gets logged:.

  [CKEDITOR] range-endcontainer, [browsable object]
  [CKEDITOR] For more information go to http://docs.ckeditor.com/#!/guide/dev_errors-section-range-endcontainer

The first line is not clear. I think we should print "[CKEDITOR] error code: range-endcontainer, ..."

Or something else that would clarify what the first line means.

Change History (7)

comment:1 Changed 3 years ago by Piotrek Koszuliński

Status: newconfirmed

comment:2 Changed 3 years ago by Szymon Kupś

Owner: set to Szymon Kupś
Status: confirmedassigned

comment:3 Changed 3 years ago by Szymon Kupś

Status: assignedreview

Changed output of CKEDTIOR.warn/error functions to look like this:

[CKEDITOR] Error: range-endcontainer. [browsable object]
[CKEDITOR] For more information about this error go to [url]

Pushed branch:t/13782

comment:4 Changed 3 years ago by Marek Lewandowski

Status: reviewreview_failed

What I think @Reinmar wanted to emphasize is that it should clearly state that it's a code and I'll second to that. Please use "Error code: " as a prefix (uppercased just like you did, so it will be in line with the next message).

comment:5 Changed 3 years ago by Szymon Kupś

Status: review_failedreview

Changed printed label to "Error code:" and updated tests in branch:t/13782.

comment:6 Changed 3 years ago by Marek Lewandowski

Merged to master with git:3b05f3a.

comment:7 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy