Opened 3 years ago

Closed 3 years ago

#13850 closed Bug (fixed)

[IE] Destroying editor without iframe test fails

Reported by: Marek Lewandowski Owned by: Szymon Kupś
Priority: Normal Milestone: CKEditor 4.5.5
Component: General Version: 4.5.5
Keywords: Cc:

Description

Test /tests/tickets/13790/1 fails in IE.

Reproduced in IE11, IE8.

Attachments (1)

edge_exception.png (22.2 KB) - added by Szymon Kupś 3 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 3 years ago by Szymon Kupś

Owner: set to Szymon Kupś
Status: newassigned

comment:2 Changed 3 years ago by Szymon Kupś

Status: assignedreview

Pushed branch:t/13850. After calling remove() method on iframe, it is still returned by getFrame method on IE. Checking if parent is present can determine if iframe is still valid on IE.

comment:3 Changed 3 years ago by Marek Lewandowski

Status: reviewreview_failed

It still fails in Edge, let's make it a complete fix.

comment:4 Changed 3 years ago by Szymon Kupś

Status: review_failedassigned

Changed 3 years ago by Szymon Kupś

Attachment: edge_exception.png added

comment:5 Changed 3 years ago by Szymon Kupś

Status: assignedreview

Pushed branch:t/13850 with fix for Edge. When trying to access window.frameElement property on Edge throws an exception when frame is already removed. Surrounded getFrame() method with try/catch statement.

comment:6 Changed 3 years ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Merged to master with git:74aa134.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy