null errors reloading the page in IE

[Alfonso Martínez de Lizarrondo]

Add a smiley to the content in IE 6 and now try to reload the page, a list of errors saying that something is null will show.

This patch (it's missing the reference to this bug number as it still doesn't exists) should take care of them, but maybe there's something else that can be done:

classes/fckspecialcombo.js

@@ -192 +192 @@
 {
         this.Enabled = isEnabled ;
 
-        this._OuterTable.className = isEnabled ? '' : 'SC_FieldDisabled' ;
+        // In IE it can happen when the page is reloaded that _OuterTable is null, so check its existence
+        if ( this._OuterTable )
+                this._OuterTable.className = isEnabled ? '' : 'SC_FieldDisabled' ;
 }
 
 FCKSpecialCombo.prototype.Create = function( targetElement )

classes/fcktoolbarbuttonui.js

@@ -127 +127 @@
 
         var e = this.MainElement ;
 
+        // In IE it can happen when the page is reloaded that MainElement is null, so exit here
+        if ( !e )
+                return ;
+
         switch ( parseInt( newState, 10 ) )
         {
                 case FCK_TRISTATE_OFF :

internals/fckdomtools.js

@@ -380 +380 @@
 
         EnforcePaddingNode : function( doc, tagName )
         {
+                // In IE it can happen when the page is reloaded that doc or doc.body is null, so exit here
+                if ( !doc || !doc.body )
+                        return ;
+
                 this.CheckAndRemovePaddingNode( doc, tagName, true ) ;
                 if ( doc.body.lastChild && ( doc.body.lastChild.nodeType != 1
                                 || doc.body.lastChild.tagName.toLowerCase() == tagName.toLowerCase() ) )

[Martin Kou]

I've merged the proposed fix to trunk in [1047].

Interestingly, the bug seems to be related to the popup dialogs. While I can confirm the bug definitely occurs with the 2.5.x branch code, it didn't occur in my local trunk code which uses floating iframes for dialogs (I haven't committed the floating dialog code to trunk yet as I still need to add in the graphics stuff).