Opened 12 years ago

Closed 12 years ago

#1475 closed Bug (fixed)

Resize of dialogs isn't right in standards mode

Reported by: Alfonso Martínez de Lizarrondo Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Dialogs Version: FCKeditor 2.4.3
Keywords: Cc:

Description

I don't know if it does make any sense to change the code in fckdialog right now as it will be converted to a floating panel, but anyway, the new version should avoid this problems:

If the content loaded in the dialog is rendered in Standards mode then the calculation of the proper height isn't done properly because it uses oInnerDoc.body instead of oInnerDoc.documentElement.

Also, the resizing is only vertical, not fitting automatically widths different than the one specified in the calling code.

And the code there still uses document.all, instead of proper browser detection.

Change History (5)

comment:1 Changed 12 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

This ticket is related to #35.

comment:2 Changed 12 years ago by Martin Kou

Fixed with [1225] and [1227].

Fred: Should I wait for the floating dialog branch review before closing this ticket as fixed?

comment:3 in reply to:  2 Changed 12 years ago by Frederico Caldeira Knabben

Replying to martinkou:

Fred: Should I wait for the floating dialog branch review before closing this ticket as fixed?

For the reporter to have a better understanding of the status of the ticket, I believe it is the right thing to have it closed only when the relative fix lands to trunk.

In the mean time, we can maintain the log of the evolution of the ticket with comments, as you have precisely done.

comment:4 Changed 12 years ago by Frederico Caldeira Knabben

Component: GeneralUI : Dialogs

comment:5 Changed 12 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with #35.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy