#14742 closed Bug (worksforme)
[Edge] Editor scrolls down when trying to edit inline widget.
Reported by: | Tade0 | Owned by: | Tade0 |
---|---|---|---|
Priority: | Normal | Milestone: | |
Component: | General | Version: | 4.5.11 |
Keywords: | Cc: |
Description
Steps to reproduce
- Open http://tests.ckeditor.dev:1030/tests/plugins/widget/manual/inline in Edge
- Double-click on a placeholder widget(e.g. Dwight Hooker?) to edit it.
Expected result
The edit dialog appears.
Actual result
The edit dialog does not appear, the editor is scrolled down.
Other details (browser, OS, CKEditor version, installed plugins)
Browser: Edge.
Change History (15)
comment:1 Changed 8 years ago by
Keywords: | edge inline widget scroll dialog removed |
---|---|
Status: | new → confirmed |
comment:2 Changed 8 years ago by
Owner: | set to Tade0 |
---|---|
Status: | confirmed → assigned |
comment:3 Changed 8 years ago by
Findings so far: To reproduce the error cut & paste internally the image widget that's in the editor.
After this clicking on any widget will scroll down, but not completely, because just after pasting the string "Lena Söderberg image widget" was appended to the end of the editor and that's where the editor scrolls.
comment:4 Changed 8 years ago by
Apparently this is one of those situations, where Edge behaves differently than IE, but since CKEDITOR.env.ie
is true
, the code is executed through a path, that causes errors.
Changing how the hidden selection container is generated partially mitigated the problem (see branch:t/14742), but this is not enough to solve this bug.
comment:5 Changed 8 years ago by
Milestone: | CKEditor 4.5.11 → CKEditor 4.6.1 |
---|
comment:6 Changed 8 years ago by
Moving to 4.6.2 minor release, as 4.6.1 is mostly about polishing 4.6.0.
comment:7 Changed 8 years ago by
Milestone: | CKEditor 4.6.1 → CKEditor 4.6.2 |
---|
comment:8 Changed 8 years ago by
Milestone: | CKEditor 4.6.2 → CKEditor 4.7.0 |
---|
comment:9 Changed 8 years ago by
There seems to be some kind of race condition enabling this bug, because adding the debugger
statement in each paste
listener and observing the state of the editor was enough to make the bug not appear.
comment:10 Changed 8 years ago by
The problem is in the way the paste
event is handled in the widget plugin.
The data is modified using a regex that in Edge results in malformed content.
comment:11 Changed 8 years ago by
Previous comment is wrong.
The real problem happens in this method: http://docs.ckeditor.com/#!/api/CKEDITOR.editable-method-insertHtml
Somehow what eventually gets selected is not the content in the supplied range.
comment:12 Changed 8 years ago by
Some conclusions:
- The text that appears at the end of the editable after pasting is the ARIA label of the widget. It's not the hidden selection container - just its content.
- Putting a breakpoint anywhere will make this bug not appear - either there's some asynchronous even going on, or it's a browser bug.
Added a minimal manual test for this case.
comment:13 Changed 8 years ago by
Status: | assigned → review |
---|
Rebased with current major
and it seems the problem... went away?
comment:14 Changed 8 years ago by
Resolution: | → worksforme |
---|---|
Status: | review → closed |
It seems that bug is really gone – I can't reproduce it even on 4.5.11 version. Maybe some update for Edge fixed it?
There is similar ticket #13577