Opened 9 years ago
Closed 8 years ago
#13577 closed Bug (worksforme)
[Edge] Copying a widget scrolls the viewport
| Reported by: | Piotrek Koszuliński | Owned by: | Szymon Cofalik |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Core : Pasting | Version: | 4.5.0 |
| Keywords: | Edge | Cc: |
Description
- Open http://tests.ckeditor.dev:1030/tests/plugins/clipboard/manual/paste
- Focus a widget.
- Press CTRL+C or the paste button.
The viewport is scrolled. It happens in framed and inline editors.
Change History (18)
comment:1 Changed 9 years ago by
| Owner: | set to Szymon Cofalik |
|---|---|
| Status: | new → assigned |
comment:2 Changed 9 years ago by
comment:3 Changed 9 years ago by
| Status: | assigned → review |
|---|
comment:4 Changed 9 years ago by
| Status: | review → review_failed |
|---|
I rebased the branch and pushed one micro commit there.
A things I would like to know are:
- why the hack for IE8 can't be used on Edge too?
- if we can't use the same hack, then can we use the hack from Edge on IE8?
- why do we need to scroll again after the pastebin is removed?
I'm giving R- for not explained complexity, so a possible overcomplication.
comment:5 Changed 9 years ago by
| Status: | review_failed → assigned |
|---|
We have to have seperate hacks because IE8 is not compatible with modern browsers and does not use window.scrollY / window.scrollTop() but use document.scrollTop instead. On Edge document.scrollTop is 0 even though the content is scrolled. window.scrollY works correctly.
why do we need to scroll again after the pastebin is removed?
Because Edge scrolls down after focusing a widget. I thought it scrolls down after removing copybin but there is probably something wrong in widget focusing, so I am investigating this now.
comment:6 Changed 9 years ago by
| Status: | assigned → review |
|---|
It seems that there is something strange happening on Edge. When copybinContainer is not appended to editable, hiding selection does not cause Edge to scroll the viewport. However, when copybinContainer is appended, scroll happens. It was enough to prepend either copybinContainer or hidden selection container.
copybinContainer prepending is less intrusive because copybinContainer exists only for 100ms and is contained within widget copying, while selection hiding is used all over editor.
New solution is available on branch:t/13577c
comment:7 Changed 9 years ago by
| Milestone: | CKEditor 4.5.3 → CKEditor 4.5.4 |
|---|
comment:8 Changed 9 years ago by
| Milestone: | CKEditor 4.5.4 → CKEditor 4.5.5 |
|---|
comment:9 Changed 9 years ago by
| Milestone: | CKEditor 4.5.5 → CKEditor 4.5.6 |
|---|
comment:10 Changed 9 years ago by
| Milestone: | CKEditor 4.5.6 → CKEditor 4.5.7 |
|---|
comment:11 Changed 9 years ago by
| Milestone: | CKEditor 4.5.7 → CKEditor 4.5.8 |
|---|
comment:12 Changed 9 years ago by
| Milestone: | CKEditor 4.5.8 → CKEditor 4.5.9 |
|---|
comment:13 Changed 9 years ago by
| Milestone: | CKEditor 4.5.9 → CKEditor 4.5.10 |
|---|
comment:14 Changed 8 years ago by
| Milestone: | CKEditor 4.5.10 → CKEditor 4.5.11 |
|---|
Moving tickets to the next milestone.
comment:16 Changed 8 years ago by
| Milestone: | CKEditor 4.5.11 → CKEditor 4.6.1 |
|---|
comment:17 Changed 8 years ago by
| Milestone: | CKEditor 4.6.1 → CKEditor 4.6.2 |
|---|
comment:18 Changed 8 years ago by
| Milestone: | CKEditor 4.6.2 |
|---|---|
| Resolution: | → worksforme |
| Status: | review → closed |
It's been a while, and looks like Edge team has fixed this bug, as it's no longer reproducible at our latest master.
Pushed branch:t/13577b with a fix and a note in manual test.