Opened 3 years ago

Closed 3 years ago

#14790 closed Task (fixed)

WebSpellChecker plugins moono-lisa skin adjustments.

Reported by: kkrzton Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.6.0
Component: UI : Skins Version:
Keywords: Cc:

Description

Related to t/14569.

While the WebSpellChecker plugin (WSC and SCAYT) is quite important, we should make sure it looks good with moono-lisa skin.

After checking with moono-lisa, the plugin looks well, only a few cosmetic changes need to be done (margins, some button alignments, etc).

Change History (8)

comment:1 Changed 3 years ago by kkrzton

Status: newconfirmed

comment:2 Changed 3 years ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:3 Changed 3 years ago by kkrzton

Created an issue and PR in wsc plugin repo #37.

comment:4 Changed 3 years ago by kkrzton

Created an issue and PR in scayt plugin repo #130.

comment:5 Changed 3 years ago by kkrzton

Status: assignedpending

Task will be closed when both PRs gets merged.

comment:6 Changed 3 years ago by kkrzton

comment:7 Changed 3 years ago by kkrzton

While this ticket is related to #14569 it does not depend on it and do not block #14569 from merging to major.

comment:8 Changed 3 years ago by kkrzton

Resolution: fixed
Status: pendingclosed

The wsc PR has been accepted (https://github.com/WebSpellChecker/ckeditor-plugin-wsc/issues/37#issuecomment-246967951).

While both PRs were accepted we can close this task.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy