Opened 3 years ago

Closed 3 years ago

#16395 closed Bug (invalid)

minified build missing widgetcommon/icons folder thus showing blank toolbar buttons

Reported by: andy stevko Owned by:
Priority: Normal Milestone:
Component: General Version:
Keywords: Cc:

Description

Steps to reproduce

  1. download both full and minified builds for this configuration

http://ckeditor.com/builder/0439a96a750795048b8796566a7b1932

  1. display app with editor & toolbar using full build.
  2. display app with editor & toolbar using minified build.
  3. compare toolbar icons displayed

Expected result

Identical toolbar buttons & icon displayed

Actual result

Full build showed entire toolbar. Minified build showed same buttons but with two missing icons. dev tools identified 404 responses from .../ckeditor-min/plugins/widgetcommon/icons/widgetcommonBox.png .../ckeditor-min/plugins/widgetcommon/icons/widgetcommonQuotebox.png

Identified folder from full download as missing from minified download .../ckeditor-min/plugins/widgetcommon/icons

Other details (browser, OS, CKEditor version, installed plugins)

latest version of ckeditor downloaded 10/20/2016 inline editor recent chrome and firefox browsers

Attachments (1)

ckeditor-missing-icons.png (9.1 KB) - added by andy stevko 3 years ago.
screen shot of minified toolbar with missing icons

Download all attachments as: .zip

Change History (2)

Changed 3 years ago by andy stevko

Attachment: ckeditor-missing-icons.png added

screen shot of minified toolbar with missing icons

comment:1 Changed 3 years ago by Jakub Ś

Resolution: invalid
Status: newclosed

There is a problem with this custom plugin.

If you use icons property, the icon name should be same as plugin name. If icon names are different, you should use addButton method:

editor.ui.addButton && editor.ui.addButton( 'ButtonName', {
	label: 'Button Label',				
	command: commandName,
	toolbar: 'insert,10'
	icon: this.path + 'icons/widgetcommonQuotebox.png'
} );	


It can also be used with widgets - please see image2 for example: https://github.com/ckeditor/ckeditor-dev/blob/master/plugins/image2/plugin.js#L92-L96
Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy