Opened 12 years ago

Closed 12 years ago

#1642 closed Bug (fixed)

window.onresize causes flicker running in chrome

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: FCKeditor 2.6
Component: General Version:
Keywords: Review+ Cc:

Description

While setting the Write Area extension one of the problems was that the editor did flicker continously, it was very annoying and finally I found that it was due to the window.onresize of the fckeditor.html and fckdialog.html

The problem is that in this situation it gets the event also from the inner frames, so it never ends the resizing.

Attachments (1)

1642.patch (2.6 KB) - added by Alfonso Martínez de Lizarrondo 12 years ago.
Proposed SVN patch

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1642.patch added

Proposed SVN patch

comment:1 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Status: newassigned

The proposed patch includes the required changes: get the event and check the document with

		// Running in Chrome makes the window receive the event including subframes.
		// we care only about this window. Ticket #1642
		if ( e && e.originalTarget !== document )
				return ;

but it also includes some little clean up, in my test everything seems to keep working fine.

comment:2 Changed 12 years ago by Martin Kou

Keywords: Review+ added; Review? removed

The only real change in the patch is the event.originalTarget check for Gecko, the other changes are cosmetic changes. So it shouldn't break anything, and it didn't in my tests. So I'm giving it a Review+.

comment:3 Changed 12 years ago by Alfonso Martínez de Lizarrondo

Milestone: FCKeditor 2.6
Resolution: fixed
Status: assignedclosed

Fixed with [1188]

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy