#1643 closed Bug (fixed)
several strict warnings
Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Alfonso Martínez de Lizarrondo |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.6 |
Component: | General | Version: | |
Keywords: | Review+ | Cc: |
Description
Running with strict warnings On in Firefox shows several little problems in the console. Due to other pending changes I can't generate a clean diff to fix all of them, so this fixes just some and the others will be fixed later
Attachments (3)
Change History (10)
Changed 17 years ago by
Attachment: | 1643.patch added |
---|
comment:1 Changed 17 years ago by
Keywords: | Review? added |
---|
The changes shouldn't affect the behavior at all
Changed 17 years ago by
Attachment: | 1643_2.patch added |
---|
comment:2 Changed 17 years ago by
Review+ for your changes Alfonso, but I was still having some warnings. I've attached a new patch, which includes also the changlog entry.
There is still one warning that I don't feel sure on how to solve it:
function eval must be called directly, and not by way of a function of another name ... editor/_source/fckeditorapi.js Line 124
But I think we can live with it.
Changed 17 years ago by
Attachment: | 1643_3.patch added |
---|
comment:3 Changed 17 years ago by
The latest proposal includes the removal of a duplicate HasFocus in fck.js.
comment:4 Changed 17 years ago by
Keywords: | Review+ added; Review? removed |
---|
the third patch fixes all the main issues (maybe there are other problems after using some commands or dialogs, but they can be fixed later).
For the eval, Firefox 3 doesn't use it, instead it injects a <script> in the parent element like it's done in Safari.
comment:6 Changed 17 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:7 Changed 17 years ago by
Milestone: | → FCKeditor 2.6 |
---|
fix for several of the warnings