Opened 10 years ago

Closed 7 years ago

#1644 closed Task (fixed)

Proposal: remove references to cursor: hand; in css

Reported by: Alfonso Martínez de Lizarrondo Owned by: Alfonso Martínez de Lizarrondo
Priority: Normal Milestone: CKEditor 3.4
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Only IE 5.5 needs the "cursor: hand;" rule, IE6 and every other browser will understand properly the "cursor: pointer;"

By removing those rules we avoid some warnings in the error consoles about the styles.

Attachments (1)

1644.patch (2.2 KB) - added by Alfonso Martínez de Lizarrondo 8 years ago.
Proposed patch

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

What about IE 5.5 compatibility? We haven't dropped it yet.

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

The only drawback for them would be that they won't see the hand cursor on some elements.

I think that they have greater problems (like the lack of patches since it was EOL some time ago and I doubt that there are too many developers dedicating a machine just to keep that ugly browser around, so their experience in the web must be already somehow unpleasant).

According to http://www.w3schools.com/browsers/browsers_stats.asp the percentage of IE5 (that means 5.0 and 5.5) is 1.5%, and it keeps going down. In a splitted comparison I think that the use of 5.0 is slightly higher than 5.5 because that's the default browser in W2000, so that leaves no more than 0.8% of users with that browser. Losing a hand cursor isn't a big problem from my point of view.

In fact, forcing them somehow to upgrade would be beneficial for everybody.

Changed 8 years ago by Alfonso Martínez de Lizarrondo

Attachment: 1644.patch added

Proposed patch

comment:3 Changed 8 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review? added
Milestone: CKEditor 3.4
Owner: set to Alfonso Martínez de Lizarrondo
Status: newassigned

IE 5.5 isn't supported in CKEditor so there's no reason to keep the "cursor: hand" statements

comment:4 Changed 7 years ago by Frederico Caldeira Knabben

Keywords: Confirmed Review+ added; Discussion Review? removed

comment:5 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Resolution: fixed
Status: assignedclosed

Fixed with [5636]

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy