Opened 8 years ago
Closed 8 years ago
#16919 closed Task (fixed)
Embedbase plugin should explicitly require dialog plugin
| Reported by: | Tomasz Jakut | Owned by: | Tomasz Jakut |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 4.7.0 |
| Component: | General | Version: | 4.7.0 |
| Keywords: | Cc: |
Description
embedbase plugin calls CKEDITOR.dialog.add to add dialog for embedding content. However it does not explicitly require dialog plugin. This call works only because embedbase requires widget plugin and widget plugin requires clipboard, which requires dialog plugin… It creates tight-coupling between clipboard and embed plugin without any sensible reason.
The fix for this situation is very easy: embedbase should explicitly requires dialog plugin.
Change History (4)
comment:1 Changed 8 years ago by
| Owner: | set to Tomasz Jakut |
|---|---|
| Status: | new → assigned |
comment:2 Changed 8 years ago by
| Status: | assigned → review |
|---|
comment:3 Changed 8 years ago by
| Milestone: | → CKEditor 4.7.0 |
|---|
comment:4 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
Merged without changelog entry, it will be added for a follow-up task.
Note: See
TracTickets for help on using
tickets.
Submitted PR.