#16919 closed Task (fixed)

Embedbase plugin should explicitly require dialog plugin

Reported by: Tomasz Jakut Owned by: Tomasz Jakut
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.7.0
Keywords: Cc:

Description

embedbase plugin calls CKEDITOR.dialog.add to add dialog for embedding content. However it does not explicitly require dialog plugin. This call works only because embedbase requires widget plugin and widget plugin requires clipboard, which requires dialog plugin… It creates tight-coupling between clipboard and embed plugin without any sensible reason.

The fix for this situation is very easy: embedbase should explicitly requires dialog plugin.

Change History (4)

comment:1 Changed 21 months ago by Tomasz Jakut

Owner: set to Tomasz Jakut
Status: newassigned

comment:2 Changed 21 months ago by Tomasz Jakut

Status: assignedreview

comment:3 Changed 21 months ago by Marek Lewandowski

Milestone: CKEditor 4.7.0

comment:4 Changed 21 months ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed

Merged without changelog entry, it will be added for a follow-up task.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy