Opened 8 months ago

Closed 7 months ago

#16920 closed Bug (fixed)

Several plugins not using dialog as a direct dependency

Reported by: Marek Lewandowski Owned by: kkrzton
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.7.0
Keywords: Cc:

Description

Originally #16919 has shown that some widget plugins doesn't have dialog specified as a dependency, while directly calling dialog methods. It's an anti-pattern that we need to fix now, that we're removing dialog dependency from clipboard plugin.

So far aforementioned ticket fixes just one Embedbase plugin, but there are more that needs to be reviewed.

Change History (4)

comment:1 Changed 8 months ago by Marek Lewandowski

Status: newconfirmed

comment:2 Changed 7 months ago by kkrzton

Owner: set to kkrzton
Status: confirmedassigned

comment:3 Changed 7 months ago by kkrzton

Status: assignedreview

comment:4 Changed 7 months ago by Marek Lewandowski

Resolution: fixed
Status: reviewclosed
Summary: Widget plugins not using dialog as a direct dependencySeveral plugins not using dialog as a direct dependency
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy