Opened 18 years ago
Closed 14 years ago
#188 closed Bug (fixed)
z-index of Image in editor prevents toolbar action
| Reported by: | Owned by: | Frederico Caldeira Knabben | |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.6.1 |
| Component: | General | Version: | |
| Keywords: | IBM SF IE | Cc: | satya_minnekanti@… |
Description
Steps:
- Add image to the Editor.
- Resize if necessary so that height and width extend beyond editor input.
- Use scroll bar so that top image size handles overlay the toolbar icons.
- Click any toolbar icon.
You will see that nothing happens. I've tried to change the z-index, but inline styles are removed or replaced in editor (i.e. when toggling between design and html mode).
Thanks!
Moved from SF:
http://sourceforge.net/tracker/index.php?func=detail&aid=1589572&group_id=75348&atid=543653
Attachments (4)
Change History (31)
comment:1 Changed 18 years ago by
comment:2 Changed 18 years ago by
| Reporter: | changed from Frederico Caldeira Knabben to johnv@… |
|---|
comment:3 Changed 18 years ago by
| Keywords: | IE Confirmed CantFix added |
|---|---|
| Resolution: | → wontfix |
| Status: | new → closed |
Confirmed with IE6 and IE7. Firefox is ok.
I don't believe we have something to do here. This is a IE behavior "by design" (like they like to call their bugs). It probably adds a transparent object over the image that caches mouse click events. This is why we also see the image handles outside the editor area.
Maybe IE8 will fix it?
I'm not that optimist. To make it happen we should first of all make MS note that someone cares about it. But their "Feedback" site is closed, at least right now:
https://connect.microsoft.com/IE
Maybe we'll have some lucky in the near future.
comment:8 Changed 15 years ago by
Changed 14 years ago by
comment:10 Changed 14 years ago by
| Resolution: | wontfix |
|---|---|
| Status: | closed → reopened |
Just came to my mind an idea that seems to workaround this issue. We can use "onmouseup", instead of "onclick".
The drawback is that it will fire the button if we move the mouse over the toolbar and "mouse up". This doesn't look like a huge problem though and it's a good compromise to have this important issue finally fixed.
The patch includes fixes to "listblock" and "menu" because of #7586.
comment:11 Changed 14 years ago by
| Owner: | set to Frederico Caldeira Knabben |
|---|---|
| Status: | reopened → review |
Changed 14 years ago by
| Attachment: | 188_2.patch added |
|---|
comment:12 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Without considering other things the attached patch should be just enough to make it work.
comment:13 Changed 14 years ago by
| Cc: | satya_minnekanti@… added |
|---|---|
| Keywords: | IBM added |
comment:14 Changed 14 years ago by
| Keywords: | Confirmed removed |
|---|---|
| Status: | review_failed → review |
I've checked your patch, but it brings back several issues related to toolbar elements that are selectable and draggable.
I would ask to please re-consider the first patch.
comment:15 Changed 14 years ago by
| Status: | review → review_passed |
|---|
comment:16 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [6971].
comment:17 Changed 14 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|
comment:19 Changed 14 years ago by
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
comment:20 Changed 14 years ago by
| Milestone: | CKEditor 3.6.1 |
|---|
Changed 14 years ago by
| Attachment: | 188_3.patch added |
|---|
comment:21 Changed 14 years ago by
| Milestone: | → CKEditor 3.6.1 |
|---|---|
| Status: | reopened → review |
The difference with this new patch is that it simply cancels the onclick event as well (on IE), which seems to be enough to avoid #8007.
Curiously, canceling onclick is necessary for the button code only.
comment:22 Changed 14 years ago by
| Status: | review → review_failed |
|---|
Rich combo is still affected by tc @ #8007
comment:23 Changed 14 years ago by
It looks like combo elements are losing their white background in IE8/Quirks and IE6 with this patch (it also happened with the patch that was reverted).
Changed 14 years ago by
| Attachment: | 188_4.patch added |
|---|
comment:24 Changed 14 years ago by
| Status: | review_failed → review |
|---|
Just in case, to avoid other unknown IE quirks, I'm cancelling the onclick event on the other changed parts of the code as well. It fixed #8007 for the combos and fortunately fixed the background issue as well.
comment:25 follow-up: 26 Changed 14 years ago by
| Keywords: | CantFix removed |
|---|---|
| Status: | review → review_passed |
...and fortunately fixed the background issue as well.
Are you pointing to #4029, I saw no relationship with the patch here, and I can still reproduce that issue with zh-cn language code.
comment:26 Changed 14 years ago by
Replying to garry.yao:
...and fortunately fixed the background issue as well.
Are you pointing to #4029, I saw no relationship with the patch here, and I can still reproduce that issue with zh-cn language code.
No, sorry for not been clearer. It was about comment:23, which is a little bit different. But in fact that comment doesn't have enough details to be properly understood. Wiktor gave me the details with Skype.
The problem was that the background of the combos was disappearing *when clicking on them*. #4029 says that it is always removed, no matter what.
comment:27 Changed 14 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review_passed → closed |
Fixed with [7036].
https://sourceforge.net/tracker/index.php?func=detail&aid=1662158&group_id=75348&atid=543653 has been marked as dup.
Moved from SF. Original poster: alfonsoml