IE: Protected source for comments is broken

[Frederico Caldeira Knabben]

The fix for #2263 is breaking source protection in IE SVN nightly.

To replicate:

1. Click source.
2. Add <!-- test --> to the source.
3. Press Source again to revert to design mode.
4. Press Source again, and you have a "null" cannot be null.

[Frederico Caldeira Knabben]

The following is a proposal fix for the part of the code that is throwing the error:

Index: D:/FCKeditor/SVN/FCKeditor/local/editor/_source/internals/fck.js
===================================================================
--- D:/FCKeditor/SVN/FCKeditor/local/editor/_source/internals/fck.js    (revision 2221)
+++ D:/FCKeditor/SVN/FCKeditor/local/editor/_source/internals/fck.js    (working copy)
 -1111,8 +1111,10 @@
                {
                        if ( typeof( this.Elements[i] ) == 'string' )
                        {
-                               node.innerHTML = this.Elements[i] ;
-                               this.Elements[i] = node.firstChild ;
+                               // For IE, we need to do this trick to avoid loosing comment
+                               // only HTML.
+                               node.innerHTML = '<div>&nbsp;</div>' + this.Elements[i] ;
+                               this.Elements[i] = node.removeChild( node.childNodes[1] ) ;
                        }
                }
        }

But then, there are still other things to get fixed to make it work.

[Frederico Caldeira Knabben]

Sorry, Trac didn't like my inline diff... here you have it: ​http://pastebin.com/f637ed2bf

[Martin Kou]

Ok... apart from the weird IE bug in which you can't put a bare comment inside a node and expect it to appear in the DOM... there's also the issue that FCKeditor puts protected code as plain text into FCKTempBin, and those plain text should never be converted to DOM nodes at all.

Proposing a patch to fix both issues.

[Frederico Caldeira Knabben]

The proposed patch is ok. In ​my previously proposed patch I got also the chance with this fix to use removeChild to retrieve the final element so we release the reference to the temporary node. Couldn't it be used here too? (basically node.firstChild.removeChild( node.firstChild.lastChild ) at line 1118)

[Martin Kou]

Fixed with [2258].

Click here for more info about our SVN system.