Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#2263 closed Bug (fixed)

Editor - anchor - java script error

Reported by: Gobinath Owned by: Martin Kou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: General Version: FCKeditor 2.6
Keywords: Confirmed IE Review+ Cc: gobinath@…

Description

Click the anchor button and give the name as test.then click source button.then return back from source(reclicking that source button).then click only one time undo button.then click source button.that time java script error is occoured.This problem only in ie. Firefox is having no problem

Attachments (2)

cas_anchor.html (49 bytes) - added by Gobinath 10 years ago.
2263.patch (3.1 KB) - added by Martin Kou 9 years ago.

Download all attachments as: .zip

Change History (17)

Changed 10 years ago by Gobinath

Attachment: cas_anchor.html added

comment:1 Changed 10 years ago by Martin Kou

Keywords: Confirmed IE added; Anchor Bug removed
Priority: HighNormal

Confirmed the problem.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6.1

comment:3 in reply to:  2 Changed 10 years ago by Gobinath

Replying to fredck:

could u tell tell me where the problem of that?

comment:4 Changed 10 years ago by Martin Kou

2.6.1 is nearing release, so new and non-critical tickets are being re-targeted away from it.

comment:5 Changed 10 years ago by Gobinath

still i have problem with anchor tag.Could i confirm it with you in new release?

comment:6 in reply to:  5 Changed 9 years ago by Gobinath

sorry for inconvenience. please tell me where i have to change the source to rectify this problem?i need to solve this problem.

comment:7 Changed 9 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 9 years ago by Martin Kou

Attachment: 2263.patch added

comment:8 Changed 9 years ago by Martin Kou

Keywords: Review? added

comment:9 Changed 9 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:10 Changed 9 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [2139].

Click here for more info about our SVN system.

comment:11 Changed 9 years ago by Scott McNaught

Hello,

The fix for #2263 is breaking source protection in IE SVN nightly. http://dev.fckeditor.net/ticket/2263

Basically the elements array is completely nulled out.

ToElements : function() {

var node = FCK.EditorDocument.createElement( 'div' ) ; for ( var i = 0 ; i < this.Elements.length ; i++ ) {

if ( typeof( this.Elements[i] ) == 'string' ) {

node.innerHTML = this.Elements[i] ; this.Elements[i] = node.firstChild ; <--------- This line node.firstChild is null

}

}

}

To replicate, visit http://www.fckeditor.net/nightly/fckeditor/_samples/default.html Click source Add <!-- test --> to the source, Press Source again to revert to design mode Press Source again, and you have a "null" cannot be null

comment:12 Changed 9 years ago by Scott McNaught

Resolution: fixed
Status: closedreopened

comment:13 Changed 9 years ago by Frederico Caldeira Knabben

Milestone: FCKeditor 2.6.3

comment:14 Changed 9 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: reopenedclosed

@Scott, I've opened a dedicated ticket for it: #2368.

comment:15 Changed 9 years ago by Alfonso Martínez de Lizarrondo

This patch has caused #2411

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy