Opened 10 years ago

Closed 10 years ago

#2854 closed New Feature (fixed)

Move table dialog to trunk.

Reported by: Martin Kou Owned by: Martin Kou
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version: SVN (FCKeditor) - Retired
Keywords: Review+ Cc:

Description

The table dialog didn't make it to v3 beta. It needs to be moved to the trunk with a review to both its UI and logic.

Attachments (3)

2854.patch (47.2 KB) - added by Martin Kou 10 years ago.
2854_2.patch (25.4 KB) - added by Martin Kou 10 years ago.
2854_3.patch (25.8 KB) - added by Martin Kou 10 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by Martin Kou

Status: newassigned

Some issues to be fixed:

  1. Alignment does not work in IE.
  2. Changes in cell padding and cell spacing are not visible immediately in IE.
  3. Not possible to create table within table.
  4. Better visual grouping of input fields needed.
  5. Not possible to create and edit table headers.

comment:2 Changed 10 years ago by Martin Kou

Keywords: Review? added

Quite a number of things were fixed in the patch:

  1. The table dialog is refactored to use the setup/commit system.
  2. Changing table alignment no longer crashes in IE.
  3. Changing cell padding and spacing are now effective immediately in IE.
  4. It's now possible to create table within table. If you want to test editing table properties, change the command for the table button in plugin.js to "tableProperties".
  5. Visual grouping of fields is improved.
  6. It's now possible to create and edit table headers as in v2.6.4.
  7. Fixed the issue where the dialog does not detect a selected table when a table as a control in IE.
  8. Fixed an issue in the wysiwygarea plugin which causes insertion of block elements inside a block limit element (e.g. inserting a table inside a td) to raise JavaScript errors.

Changed 10 years ago by Martin Kou

Attachment: 2854.patch added

Changed 10 years ago by Martin Kou

Attachment: 2854_2.patch added

comment:3 Changed 10 years ago by Martin Kou

Fixed duplicated patches generated by TortoiseSVN.

comment:4 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed
  • As stated on #2792, we must not have the "defaultValues" configuration section. Any kind of customization in this sense must be done by using the JavaScript API.
  • The dialogs are getting registered twice, one at plugin.js and again at table.js. Why is that done in this way?
  • Most of the fields in the dialog are quite simple and their logic could be easily separated inside each UI element. There was no need to use the setupValue and commitValue artifact for all of them, as it just makes the dialog logic hard to follow. The dialog is functional, and we can even commit it as is, but this is really bad coding.

comment:5 Changed 10 years ago by Martin Kou

Keywords: Review? added; Review- removed

Fixed the following issues:

  1. Removed all defaultValues in configuration.
  2. Moved all setup logic to setup() functions and most commit logic to commit() functions. The following 3 commit items are still in onOk() because of interdependency issues:
    • Rows and columns
    • Table headers, which depends on rows and columns
    • Width and height, which are interdependent
  3. Simplified the validation logic in table dialog.
  4. Added alert messages when validation fails.
  5. Fixed the issue where the table caption cannot be cleared.
  6. Fixed the issue where table width cannot be set to percentages.

Changed 10 years ago by Martin Kou

Attachment: 2854_3.patch added

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

Attention, the patch contains an unresolved conflict on _source/plugins/toolbar/plugin.js. Be sure to fix that before committing.

comment:7 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Thanks for the notifications, the conflict is resolved.

Fixed with [3047].

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy