Opened 16 years ago
Closed 16 years ago
#2853 closed Task (fixed)
Move image dialog to trunk.
| Reported by: | Martin Kou | Owned by: | Artur Formella |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Review+ | Cc: |
Description
The image dialog didn't make it to v3 beta, so it needs to be moved to trunk with a review to both its UI and its logic.
Attachments (4)
Change History (15)
Changed 16 years ago by
| Attachment: | 2853.patch added |
|---|
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
| Status: | new → assigned |
|---|
comment:3 Changed 16 years ago by
| Owner: | Martin Kou deleted |
|---|---|
| Status: | assigned → new |
Oops! I was planning to accept it when I got the table dialog almost done. Turns out Artur got a patch out. :-)
comment:4 Changed 16 years ago by
| Keywords: | Confirmed added |
|---|---|
| Owner: | set to Artur Formella |
Ok. So I will finish it :)
Changed 16 years ago by
| Attachment: | 2853.2.patch added |
|---|
comment:6 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
- The configurations must not be defined in "levels". They must go all directly under CKEDITOR.config. See #2822.
- The uploadTab and showPreview setting can be avoided, as discussed previously. Such customizations can be done by API. I would live the browseServer option as this is quite used.
- The imageDialog variable declaration, other than missing the "var" statement, is polluting the global namespace. It must go inside an anonymous function declaration.
- All variables set to functions (like onImgLoadEvent and onSizeChange) have no semicolon after the function definition, and some of them is is missing the "var" statement.
Changed 16 years ago by
| Attachment: | 2853_3.patch added |
|---|
comment:7 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:8 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The pushDefault() and popDefault() functions have been removed recently (see #2803). The patch throw errors because of this. Please update your local copy, fix this issue and provide a new patch.
That's the only problem so far. Getting that fixed will probably bring a Review+ for it.
Changed 16 years ago by
| Attachment: | 2853_4.patch added |
|---|
comment:9 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
Ok. I removed pushDefault() and popDefault().
comment:10 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Note: See
TracTickets for help on using
tickets.
I got it almost done