Move link dialog to v3 trunk.

[Martin Kou]

The link dialog did not make it to the v3 beta. It should be moved to trunk with all discovered issues (#2831, #2832, #2833, #2839) fixed.

[Martin Kou]

Temporary fakeobjects plugin for making the patch work.

[Martin Kou]

#2832 needs to be fixed in the fakeobjects plugin, which Fred is working on.

2852.patch needs a fakeobjects plugin to work, however. So I'm providing a temporary fakeobjects patch which enables the patch to work correctly but does not fix #2832.

[Martin Kou]

#2831, #2833, #2839 are marked as dup to this ticket.

[Martin Kou]

Updated the patch to use the new fakeobjects system, with some related fixes and additions to the fakeobjects system:

1. Added CKEDITOR.editor::restoreRealElement() in fakeobjects plugin to convert a fake object back to the real element so that dialogs can edit the real element.
2. Added a new argument "realElementType" in CKEDITOR.editor::createFakeElement() in fakeobjects plugin for specifying the element type to display instead of "img" in the element path bar.
3. Modified the pagebreak plugin so that page breaks are displayed as "div" elements in the element path bar when selected, instead of "img".
4. Fixed erroneous detection of anchors in the document in the Link dialog.

[Martin Kou]

Ok, one more update with two more things fixed.

1. The issue in #2832 is fixed. So #2832 is marked as a dup to this ticket.
2. Creating a link from a collapsed selection does not work.

[Martin Kou]

Retracted review request... Still some IE bugs to be fixed (e.g. setting name attribute to an <a> does not work in IE the usual way).

[Martin Kou]

1. Fixed <a> name change bugs in IE.
2. Added CSS styles for non-empty anchors.

[Martin Kou]

Fixed duplicated patches generated by TortoiseSVN.

[Frederico Caldeira Knabben]

• The changes at htmlparser/element.js:
  • There is no need to lower case the attribute name. It will always be lowercased.
  • There is no need to trim the replace. It's enough to change the reges to: ckeClassRegex = /(^|\s+)cke_[\s]*/g. It also makes the regex more correct.
  • The regex declaration is reusing the multiline "var" statement for sortAttribs, which is to be avoided. Having several "var"s one after the other is automatically optimized by the packager.

• The "defaultValues" are to be removed from the configurations. See #2792. The uploadTab, showAdvancedTab and showTargetTab should also be removed in favor of the API features.

• The plugin configurations must not go under the CKEDITOR.config.link object, but directly under CKEDITOR.config. Maybe prefixed with "link_". See #2822.

• Reusing a single "var" statement for all local functions in the link dialog make it a big mess. Multiline variable declarations should have its own "var" statement.

• It's a pity to see all the logic being done inside the onOk function. That's is not the way to go, but that's the way it will be as we don't have time to change it now. This dialog is be rewritten later, and hopefully we'll not have that much people basing their custom plugins on it.

[Martin Kou]

/(^|\s+)cke_[^\s]*/g

alone wouldn't work. Let's say I have "cke_sth sth_else" as the class attribute, if I run replace with that and an empty string I'd end up with " sth_else", which is wrong because there's an extra space in front of the value. If trim() is not called then a second regex would still be needed to fix that, which is just doing the same thing as a trim anyway.

[Martin Kou]

Ok. The following are fixed:

1. defaultValues is removed.
2. Config sub-namespaces are removed. Now link related configs are named as config.linkCamelCase, following the naming conventions in config.js.
3. Multi-line var declarations are changed to conform to the coding style guidelines.
4. ckeClassRegex is changed to

   /(^|\s+)cke_[^\s]*/g
   }}}, but after replacing with it an ltrim() is still done.
    5. Removed unnecessary toLowerCase() in htmlparse/element.js.
   

[Martin Kou]

Ok, another patch posted. The previous patch missed the newly added files and had a lot of unnecessary newline changes.

[Martin Kou]

New patch with pushDefault() and popDefault() removed due to #2803.

[Martin Kou]

Fixed a remaining reference to config.link sub-namespace in the link plugin.

[Frederico Caldeira Knabben]

Please don't forget the images when committing (they were not included into the patch, obviously).

[Martin Kou]

Fixed with [3048].