Opened 10 years ago

Closed 10 years ago

#2980 closed Bug (fixed)

Table feature does not provide ability to modify tables in V3

Reported by: Damian Owned by: Martin Kou
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: IBM Confirmed Review+ Cc:

Description

It is not possible to modify a table after it has been inserted into the document using the editor.

Attachments (1)

2980.patch (42.6 KB) - added by Martin Kou 10 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 10 years ago by Garry Yao

Keywords: Confirmed added

We've already have the logic ready, waiting for context menu to be implemented as a holder container to introduce Edit Table feature.

comment:2 Changed 10 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: newclosed

Fixed with [3170] for #3057.

comment:3 Changed 10 years ago by Damian

Resolution: fixed
Status: closedreopened

This issue has not been fixed with the introduction of the context menu.

It would be preferable if this bug remained open until the implementation for Edit Table was actually integrated so as to keep track of its progress.

comment:4 Changed 10 years ago by Garry Yao

Instead I the feature is already implemented in trunk.

comment:5 Changed 10 years ago by Damian

Agreed, the ability to modify table properties is functional in the trunk.

I believe my original description of this bug is too ambiguous, sorry for the confusion. The intention of this bug report was to highlight that the following abilities in the table editing feature are missing:

  • Insert column before/after
  • Remove columns
  • Insert row before/after
  • Remove rows
  • Edit Cell properties

comment:6 Changed 10 years ago by Frederico Caldeira Knabben

Priority: NormalHigh

comment:7 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: reopenednew

Changed 10 years ago by Martin Kou

Attachment: 2980.patch added

comment:8 Changed 10 years ago by Martin Kou

Keywords: Review? added

The patch needs #3001's patch to work correctly in IE. It should work in other browsers.

comment:9 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

When committing, please remove the outer (function(){})(); that has been added to the table plugin as it's not needed.

comment:10 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3333].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy