V3: Document Properties plugin

[Artur Formella]

Document Properties plugin with Select Color dialog.

[Frederico Caldeira Knabben]

This one needs full page support, which is not yet available and it's not our priority now. Please hold on with this ticket.

[Artur Formella]

#628 is connected with ticket.

[Frederico Caldeira Knabben]

#4588 has been marked as DUP.

[Frederico Caldeira Knabben]

Milestone CKEditor 3.x deleted

[Sa'ar Zac Elias]

INCOMPLETE implementation of the plugin

[Garry Yao]

Looks cool, but the patch breaks IE6/7, and link color options doesn't persist between mode switches - as it's quite difficult to handle them correctly, how about leave it for now?

[Sa'ar Zac Elias]

Replying to garry.yao:

the patch breaks IE6/7

Another case of special usage of getAttribute, fixed.

link color options doesn't persist between mode switches - as it's quite difficult to handle them correctly, how about leave it for now?

I removed those options, and merged the remaining options in that tab with the background tab, creating the new "design" tab.
In addition, a few minor glitches had been fixed.

[Garry Yao]

Some glitches around charset were found:

1. Confirm an empty dialog will result in the following meta:

   <meta content="text/html; charset=" http-equiv="content-type" />
   

2. "text/html" will be forced that show no respect of what specified by user;
3. Other way of specifying charset is not supported:

   <meta http-equiv="charset" content="iso-8859-1">
   

The plugin should not be loaded at all in non-fullpage mode.

[Anna Tomanek]

Just one minor note regarding the dialog window texts. I would suggest changing the following label:

Is:
Nonscrolling (Fixed) Background
Should be:
Non-scrolling (Fixed) Background

[Sa'ar Zac Elias]

All of the above suggestions, including Anna's, are covered in the 3rd patch.

[Wiktor Walc]

Please make sure to commit also language updates when closing this ticket (took me a while to translate everything ;)).

Not sure if storing 'previewHtml' in language makes sense, I guess "Lorem ipsum" could be reused from the Image dialog.

[Garry Yao]

Replying to wwalc:

Please make sure to commit also language updates when closing this ticket (took me a while to translate everything ;)).

Thanks Wiktor, I didn't recognize there's still people who master every language on this planet ;)

Not sure if storing 'previewHtml' in language makes sense, I guess "Lorem ipsum" could be reused from the Image dialog.

Considering that we need a link in preview.

[Garry Yao]

Saved content type doesn't looks like a good idea, check this:

1. First load with xhtml content-type:

   <meta content="application/xhtml+xml; charset=utf-8" http-equiv="content-type" />
   

2. Open dialog do nothing and close.
3. Second load with no meta tag of content-type specified.
4. Open dialog and specify any charset;
5. Check output:

• Actual Result: application/xhtml+xml specified in the first time was enforced.

[Garry Yao]

Also we must load the plugin into fullpage sample page btw.

[Garry Yao]

Everything looks good right now except body text color is always enforced to white once open dialog, it should be instead leaving blank thus remains "inherit".

[Sa'ar Zac Elias]

Changes will be applied after the field contents had been changed.

[Garry Yao]

Nice done！

[Sa'ar Zac Elias]

Fixed with [6788].

[Sa'ar Zac Elias]

Addes icon coordinates to other skins with [6789].

[Wiktor Walc]

It looks like translations were not committed... I have added them with [7028].