#2988 closed New Feature (fixed)
V3: Document Properties plugin
Reported by: | Artur Formella | Owned by: | Sa'ar Zac Elias |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.6 |
Component: | UI : Dialogs | Version: | |
Keywords: | Cc: |
Description
Document Properties plugin with Select Color dialog.
Attachments (7)
Change History (33)
comment:1 Changed 14 years ago by
Owner: | set to Artur Formella |
---|
comment:2 Changed 14 years ago by
comment:3 Changed 14 years ago by
Milestone: | CKEditor 3.0 → CKEditor 3.x |
---|---|
Type: | Bug → New Feature |
comment:5 Changed 13 years ago by
Owner: | Artur Formella deleted |
---|
comment:8 Changed 12 years ago by
Milestone: | → CKEditor 3.6 |
---|
comment:9 Changed 12 years ago by
Owner: | set to Sa'ar Zac Elias |
---|---|
Status: | new → assigned |
Changed 12 years ago by
Attachment: | 2988.patch added |
---|
comment:10 Changed 12 years ago by
Status: | assigned → review |
---|
comment:11 follow-up: 12 Changed 12 years ago by
Status: | review → review_failed |
---|
Looks cool, but the patch breaks IE6/7, and link color options doesn't persist between mode switches - as it's quite difficult to handle them correctly, how about leave it for now?
comment:12 Changed 12 years ago by
Status: | review_failed → review |
---|
Replying to garry.yao:
the patch breaks IE6/7
Another case of special usage of getAttribute, fixed.
link color options doesn't persist between mode switches - as it's quite difficult to handle them correctly, how about leave it for now?
I removed those options, and merged the remaining options in that tab with the background tab, creating the new "design" tab.
In addition, a few minor glitches had been fixed.
Changed 12 years ago by
Attachment: | 2988_2.patch added |
---|
comment:13 Changed 12 years ago by
Status: | review → review_failed |
---|
Some glitches around charset were found:
- Confirm an empty dialog will result in the following meta:
<meta content="text/html; charset=" http-equiv="content-type" />
- "text/html" will be forced that show no respect of what specified by user;
- Other way of specifying charset is not supported:
<meta http-equiv="charset" content="iso-8859-1">
The plugin should not be loaded at all in non-fullpage mode.
comment:14 Changed 12 years ago by
Just one minor note regarding the dialog window texts. I would suggest changing the following label:
Is:
Nonscrolling (Fixed) Background
Should be:
Non-scrolling (Fixed) Background
Changed 12 years ago by
Attachment: | 2988_3.patch added |
---|
comment:15 Changed 12 years ago by
Status: | review_failed → review |
---|
All of the above suggestions, including Anna's, are covered in the 3rd patch.
Changed 12 years ago by
Attachment: | 2988_language_updates.patch added |
---|
comment:16 follow-up: 17 Changed 12 years ago by
Please make sure to commit also language updates when closing this ticket (took me a while to translate everything ;)).
Not sure if storing 'previewHtml' in language makes sense, I guess "Lorem ipsum" could be reused from the Image dialog.
comment:17 Changed 12 years ago by
Replying to wwalc:
Please make sure to commit also language updates when closing this ticket (took me a while to translate everything ;)).
Thanks Wiktor, I didn't recognize there's still people who master every language on this planet ;)
Not sure if storing 'previewHtml' in language makes sense, I guess "Lorem ipsum" could be reused from the Image dialog.
Considering that we need a link in preview.
comment:18 Changed 12 years ago by
Status: | review → review_failed |
---|
Saved content type doesn't looks like a good idea, check this:
- First load with xhtml content-type:
<meta content="application/xhtml+xml; charset=utf-8" http-equiv="content-type" />
- Open dialog do nothing and close.
- Second load with no meta tag of content-type specified.
- Open dialog and specify any charset;
- Check output:
- Actual Result: application/xhtml+xml specified in the first time was enforced.
Changed 12 years ago by
Attachment: | 2988_4.patch added |
---|
comment:20 Changed 12 years ago by
Status: | review_failed → review |
---|
comment:21 Changed 12 years ago by
Status: | review → review_failed |
---|
Everything looks good right now except body text color is always enforced to white once open dialog, it should be instead leaving blank thus remains "inherit".
Changed 12 years ago by
Attachment: | 2988_5.patch added |
---|
comment:22 Changed 12 years ago by
Status: | review_failed → review |
---|
Changes will be applied after the field contents had been changed.
comment:24 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | review_passed → closed |
Fixed with [6788].
comment:26 Changed 12 years ago by
It looks like translations were not committed... I have added them with [7028].
This one needs full page support, which is not yet available and it's not our priority now. Please hold on with this ticket.