Opened 8 years ago

Closed 8 years ago

#3213 closed Bug (fixed)

Change the voice readout of the editing area from "CKEditor" to "Rich Text Area"

Reported by: Martin Kou Owned by: Martin Kou
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: Accessibility Version: SVN (CKEditor) - OLD
Keywords: Oracle Review+ Cc: Senthil

Description

When focus is brought into CKEditor's editing area in our samples right now, the voice readout by JAWS is typically like this:

"Output, CKEditor Editor 1, type in text"

Output is the outer frameset's title in our sample pages. CKEditor is always read to tell the user that they're in CKEditor. Editor 1 is the editor instance's name.

It is more descriptive for screen reader users if the CKEditor part of the readout is changed to "Rich Text Editor" - so they'll know what to expect, instead of hearing a name which they may or may not understand immediately.

Attachments (5)

3213.patch (853 bytes) - added by Martin Kou 8 years ago.
3213_2.patch (1.4 KB) - added by Martin Kou 8 years ago.
3213_3.patch (1.4 KB) - added by Martin Kou 8 years ago.
3213_4.patch (1.8 KB) - added by Martin Kou 8 years ago.
3213_5.patch (1.7 KB) - added by Frederico Caldeira Knabben 8 years ago.

Download all attachments as: .zip

Change History (19)

Changed 8 years ago by Martin Kou

Attachment: 3213.patch added

comment:1 Changed 8 years ago by Martin Kou

Keywords: Review? added

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

"text area" is developers' language.

There is not reason to not accept localization for this text. So, please move it to the language file. The entry should look like this:

editorTitle : 'Rich text editor, %1'

Changed 8 years ago by Martin Kou

Attachment: 3213_2.patch added

comment:3 Changed 8 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

Please remove the '. Type in text.' part of it.

Changed 8 years ago by Martin Kou

Attachment: 3213_3.patch added

comment:5 Changed 8 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:7 Changed 8 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [3306].

Click here for more info about our SVN system.

comment:8 Changed 8 years ago by Senthil

Keywords: Review+ removed
Resolution: fixed
Status: closedreopened

After i tested the fix the reported issue still exist in IE and Safari.

comment:9 Changed 8 years ago by Frederico Caldeira Knabben

The word "CKEditor" is not anymore present in the editor code, so there is no way for JAWS to ready it. Wasn't it a cache issue?

Can you confirm it Martin, and close this ticket?

comment:10 Changed 8 years ago by Martin Kou

I've just performed a test on Senthil's machine today - I found the JAWS in Senthil's computer isn't reading the <label> in front of the editing iframe. However, if I add a <legend> instead, it's read.

Still testing <legend> on my local machines, and then I'll propose a new patch for this.

Changed 8 years ago by Martin Kou

Attachment: 3213_4.patch added

comment:11 Changed 8 years ago by Martin Kou

Keywords: Review? added

There's no way to make JAWS to read anything from Safari - it won't read anything even in Google.

So we can only fix the voice readout for IE. For Safari we'll have to wait until JAWS is properly integrated with the browser - we can't do anything to fix JAWS and Safari from JavaScript.

comment:12 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The usage on "join()" with no parameters is wrong, as it add commas between the array entries. Also, there is no benefit on using the "join trick" for small string concatenations.

I'm coming with a new patch, just to accelerate the process.

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 3213_5.patch added

comment:13 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review- removed

Martin, I've attached a new patch, please be sure my changes are ok before committing.

comment:14 Changed 8 years ago by Martin Kou

Resolution: fixed
Status: reopenedclosed

Fixed with [3338].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy