Add hotkeys for image dialog, remove link and save

[Martin Kou]

These are three of the more common dialog commands that could use hotkey combos.

[Martin Kou]

Fixed with [3385].

Click here for more info about our SVN system.

[Frederico Caldeira Knabben]

Please revert the changes related to this ticket. I've written a long "wontfix" resolution for it yesterday, but somehow my comment didn't get saved. My mistake, certainly.

There are several motivations to have this ticket invalidated:

• We should minimize the usage of keystrokes in the editor. They could easily conflict with browser specific keys (current and future). They can also collide with other well known key combinations. For example, the ​ARIA Best Practices define that the CTRL+M keystroke should be used for indentation and to switch the TAB key behavior.

• I can't easily confirm that those features are really so common:
  • Image: keystrokes are related to accessibility, and I strongly doubt that visually impaired users use this feature that much.
  • Remove Link: it's not true that this feature is so used. The really used feature is the "Create Link" command, and usually when a link is created it just stays there. Only testers use this feature that much.
  • Save: this command posts the form, which in most cases is an unwanted behavior. Developers want to have their users filling all form fields and using the appropriate submit button, instead of accidentally post the form from inside the editor.

• It's easy to anyone to add its custom keystrokes by configuration file. So, there is no sense to have all possibilities already defined in the editor by default.

• It's problematic having keystrokes for all features. If any of the features is simply removed from the toolbar, the keystroke remains active, and it becomes more complicated to deactivate the feature.

[Martin Kou]

The changes has been reverted with [3387].

[Garry Yao]

While be conservative on keystroke binding is good, it's better if CKEditor will have a default keybinding schema which doesn't conflict with most of the browsers and OSs hot-key, at least for those style commands and high-frequency commands like 'Find/Replace', perhaps we can introduce similar concepts like 'muti-mode' just like Vim, to avoid the key conflicting problem,e.g. 'ALT-F10' to enter command mode and strike at wish, 'ESC' restore to edit mode and everything is back to normal.