Opened 9 years ago

Last modified 7 years ago

#3358 new Task

Optimize 'CKEDITOR.dom.range.enlarge' on block unit

Reported by: Garry Yao Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0
Keywords: HasPatch Cc:

Description

After enlarging the range with a block unit with the following input:

<div>text^<p>paragraph</p></div>^

We'll got:

<div>^text<p>paragraph</p></div>^

No we got a partially selected block, it's better to have the 'div' been fully selected to prevent consequence operation like extractContent from resulting in unwanted node pieces, so an optimized result would be the following:

^<div>text<p>paragraph</p></div>^

Attachments (2)

3358.patch (2.7 KB) - added by Garry Yao 9 years ago.
test_range_enlarge_block.patch (4.2 KB) - added by Garry Yao 9 years ago.
Unit Test Case

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by Garry Yao

Attachment: 3358.patch added

comment:1 Changed 9 years ago by Garry Yao

Keywords: HasPatch added

The proposed patch is containing the latest patch from #3360 on which it depends.

Changed 9 years ago by Garry Yao

Unit Test Case

comment:2 Changed 8 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.0CKEditor 3.x

comment:3 Changed 7 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.x

Milestone CKEditor 3.x deleted

comment:4 Changed 7 years ago by Garry Yao

Type: BugTask

comment:5 Changed 7 years ago by Wiktor Walc

Version: 3.0
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy