Opened 16 years ago
Closed 16 years ago
#3526 closed Task (fixed)
Implement Ignore Empty Paragraph feature
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.0 |
Component: | General | Version: | |
Keywords: | Confirmed Review+ | Cc: |
Attachments (3)
Change History (10)
comment:1 Changed 16 years ago by
Status: | new → assigned |
---|---|
Type: | Bug → Task |
comment:2 Changed 16 years ago by
Keywords: | Review? added |
---|
Changed 16 years ago by
Attachment: | 3526.patch added |
---|
comment:3 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
comment:4 follow-up: 5 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|
Certain differences with v2:
- We should consider all empty block as paragraph;
- It's easier to have data processor to help with trimming empty inline elements, now we just need to consider spaces, and <br/>, later, we may even only need to consider spaces.
Changed 16 years ago by
Attachment: | 3526_2.patch added |
---|
Changed 16 years ago by
Attachment: | 3526_3.patch added |
---|
comment:5 Changed 16 years ago by
Replying to garry.yao:
Certain differences with v2:
- We should consider all empty block as paragraph;
No, the fixing should dedicate to paragraph-like block elements only.
comment:6 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
The fix is ok. I would ask you to just move the regex declaration to the very beginning of the plugin code when committing, so it doesn't need to be recreated every time the inner function get executed.
We don't need really to remove all empty paragraphs. We're talking about the IgnoreEmptyParagraphValue setting we have in V2 today, which indicates that the editor value must be empty if we just have an empty paragraph inside of it.
Also, we have also some change on #3439.
I think this fix should go in the getData function of the wysiwygarea plugin, checking the data even before calling the data processor.