Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#357 closed New Feature (fixed)

Anchor delete option on context menu

Reported by: Martin Knowles Owned by:
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version:
Keywords: Cc:

Description

At present, right-clicking on a hyperlink lets you remove the hyperlink as one of the options in the context menu. Anchors don't work this way, although you can remove the anchor from the anchor dialog by clearing it. [243] adds a Remove Anchor command on the context menu so that anchors and hyperlinks have the same UI on the context menu. This function should probably have an icon.

Change History (5)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Discussion added

This one is interesting. But, as we already have ways to easily remove anchors, we could think about it as a plugin.

Any opinion from others regarding this?

comment:2 Changed 10 years ago by Alfonso Martínez de Lizarrondo

I'm not sure that an average user will know that he can remove an anchor by clearing it in the anchor dialog, some people will try to do that, but many people won't know.

But those users that don't have the initiative to try out probably won't ever notice the context menu.

It's almost like the Copy, Cut and Paste buttons. Why are there in the toolbar and in the context menu? People can use the keyboard, but showing it clearer that they can do those actions do help.

If I'm not mistaken the proposed code is just a function from the anchor dialog and the basic wrappers to create a new command (and in the anchor dialog that code could be replaced by a call to this command), so it doesn't look like a big deal, although it means that some new strings will have to be added to the translations and maybe change also the toolbars icons to add a new one.

No other code depends on it, so it would be really easy to provide it as a plugin.

If no image is needed for the context menu then I would vote to include the code in the core commands, as that way it will be easier to track any other change in the way that anchors are handled.

comment:3 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Discussion removed
Milestone: FCKeditor 2.5

It would be ok to have it in the context menu without an icon.

Martin, as [243] contains several unrelated changes, do you think you can reduce the code to a trunk patch file attached to this ticket?

comment:4 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: newclosed

Fixed with [643].

Click here for more info about our SVN system.

I've only written down the English and Chinese translations for the AnchorDelete command though. The command's descriptive text in other languages must be done by other translators as I do not know any other languages.

comment:5 Changed 10 years ago by Alfonso Martínez de Lizarrondo

I've modified in [669] the anchor dialog to reuse this new command.

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy