Opened 8 years ago

Closed 7 years ago

#3570 closed New Feature (fixed)

Elementpath work with SCAYT

Reported by: Garry Yao Owned by: Garry Yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc: WebSpellChecker.net

Description

Elementpath should hide SCAYT marker '<span>' from end user.

Attachments (2)

3570.patch (1.1 KB) - added by Frederico Caldeira Knabben 8 years ago.
3570_2.patch (5.4 KB) - added by Garry Yao 7 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 8 years ago by Artur Formella

Keywords: Confirmed added

comment:2 Changed 8 years ago by WebSpellChecker.net

Resolution: fixed
Status: newclosed

patch is submitted in #5145

comment:3 Changed 8 years ago by Frederico Caldeira Knabben

Resolution: fixed
Status: closedreopened

It's ok to indicate that this one is supposed to be fixed by another tickets, but it should be closed only after confirming the fix one the relative ticket gets closed.

Changed 8 years ago by Frederico Caldeira Knabben

Attachment: 3570.patch added

comment:4 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review? added
Milestone: CKEditor 3.xCKEditor 3.2

comment:5 Changed 8 years ago by Frederico Caldeira Knabben

Owner: set to Frederico Caldeira Knabben
Status: reopenednew

comment:6 Changed 8 years ago by Frederico Caldeira Knabben

Status: newassigned

comment:7 Changed 8 years ago by Frederico Caldeira Knabben

Keywords: Review? removed
Milestone: CKEditor 3.2CKEditor 3.3

Maybe it's better to have a generic solution for it, like having a standard attribute to be appended to elements to be ignored in the elements path.

Changed 7 years ago by Garry Yao

Attachment: 3570_2.patch added

comment:8 Changed 7 years ago by Garry Yao

Cc: WebSpellChecker.net added
Keywords: Review? added
Version: SVN (CKEditor)

Introduce a generic config option for achieving that.

comment:9 Changed 7 years ago by WebSpellChecker.net

Here is idea. Does it make a sence to add some method to the Elementpath which allow to register set of keys which should be taken into account when Elementpath works. There should be ability to unregister this set of keys. This method can be called from plug-ins.

Ignore(
{/*String*/ param1: /*String*/value1,
 /*String*/ param2: /*String*/value2,
 ...
}

where

paramX - property name | attribute name valueX - value or part of value which paramX may contain or null which means that paramX should be checked for existance

Samples:

Ignore(
{
  "scaytid": null
});

or

Ignore(
{
  "nodeName": "span",
  "class": "ignore"
});

or

if on the page <b> is suppressed by the style:

b { font-weight: normal }

and only <strong> should be displayed then Ignore method can be called following way:

Ignore(
{
  "nodeName": "b"
});

comment:10 Changed 7 years ago by Garry Yao

The provided patch could achieve that: config.elementsPath_filters.push( function( element ) {

if( element.is( 'b' ) && element.getComputedStyle( 'font-weight' ) == 'normal' ) )

return false;

});

comment:11 Changed 7 years ago by Garry Yao

Owner: changed from Frederico Caldeira Knabben to Garry Yao
Status: assignednew

comment:12 Changed 7 years ago by Alfonso Martínez de Lizarrondo

Keywords: Review+ added; Review? removed

In the documentation it's written once 'myAttribue', just fix that before committing.

comment:13 Changed 7 years ago by Garry Yao

Status: newassigned

Fixed with [5228].

comment:14 Changed 7 years ago by Garry Yao

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy