Opened 8 years ago
Closed 8 years ago
#3633 closed Bug (fixed)
Default context menu isn't disabled in toolbar, status bar, panels...
| Reported by: | Alfonso Martínez de Lizarrondo | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Confirmed Review+ | Cc: |
Description
Load CKEditor and right click in the toolbar, status bar, any floating panel or context menu...
The default browser context menu is shown instead of showing nothing.
Attachments (4)
Change History (18)
comment:1 Changed 8 years ago by
| Keywords: | Confirmed added |
|---|---|
| Milestone: | → CKEditor 3.1 |
comment:2 Changed 8 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 8 years ago by
| Attachment: | 3633.patch added |
|---|
comment:3 Changed 8 years ago by
| Keywords: | Review? added |
|---|
comment:4 Changed 8 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Changed 8 years ago by
| Attachment: | 3633_2.patch added |
|---|
comment:5 Changed 8 years ago by
| Keywords: | Review? added; Review- removed |
|---|
I've merged preventers for toolbar and bottom part of chrome, but floatpanels have to have them separately.
comment:6 Changed 8 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:8 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:9 Changed 8 years ago by
| Keywords: | Review- added; Review+ removed |
|---|---|
| Resolution: | fixed |
| Status: | closed → reopened |
[4178] (3633_2.patch) disables context menu in source area, which is an regression.
comment:10 Changed 8 years ago by
| Keywords: | Review? added; Review- removed |
|---|
I'm proposing including first patch 3633.patch because of reason mentioned above.
Changed 8 years ago by
| Attachment: | 3633_3.patch added |
|---|
comment:11 Changed 8 years ago by
Nice catch, but the advantages of prevent at the chrome level is that we can make sure every corner of the chrome is covered.
Changed 8 years ago by
| Attachment: | 3633_4.patch added |
|---|
comment:12 Changed 8 years ago by
I'm proposing a bit more flexible solution, although your's Garry one should work fine too.
Which one is more suitable for us ?
comment:14 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
Note: See
TracTickets for help on using
tickets.
Maybe it's better to add one single event preventer on the editor chrome instead?