Opened 10 years ago

Closed 10 years ago

#3650 closed Bug (fixed)

Delete rows/columns/cells commands do not work when text is selected

Reported by: Martin Kou Owned by: Martin Kou
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:

Description

To reproduce:

  1. Create a default 2x3 table.
  2. Right click on one of the cells.
  3. Try any one of the delete rows/columns/cells commands.
  4. Nothing happens.

Attachments (2)

3650.patch (2.5 KB) - added by Martin Kou 10 years ago.
3650_2.patch (3.4 KB) - added by Martin Kou 10 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 10 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 10 years ago by Martin Kou

Attachment: 3650.patch added

comment:2 Changed 10 years ago by Martin Kou

Keywords: Review? added

comment:3 Changed 10 years ago by Martin Kou

To get correct results when reviewing, you need to apply the patch to #3656 as well.

comment:4 Changed 10 years ago by Garry Yao

Keywords: Review- added; Review? removed

Nice catch, and it works, but could you please use:

 range.getCommonAncestor();

instead of

range.getBoundaryNodes().startNode;

when range is collapsed, actually they're the same for this case, but we're indenting to deprecate 'getBoundaryNodes'.

Changed 10 years ago by Martin Kou

Attachment: 3650_2.patch added

comment:5 Changed 10 years ago by Martin Kou

Keywords: Review? added; Review- removed

comment:6 Changed 10 years ago by Garry Yao

Keywords: Review+ added; Review? removed

comment:7 Changed 10 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [3623].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy