Opened 15 years ago
Closed 15 years ago
#3650 closed Bug (fixed)
Delete rows/columns/cells commands do not work when text is selected
| Reported by: | Martin Kou | Owned by: | Martin Kou |
|---|---|---|---|
| Priority: | Must have (possibly next milestone) | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | Review+ | Cc: |
Description
To reproduce:
- Create a default 2x3 table.
- Right click on one of the cells.
- Try any one of the delete rows/columns/cells commands.
- Nothing happens.
Attachments (2)
Change History (9)
comment:1 Changed 15 years ago by
| Owner: | set to Martin Kou |
|---|---|
| Status: | new → assigned |
Changed 15 years ago by
| Attachment: | 3650.patch added |
|---|
comment:2 Changed 15 years ago by
| Keywords: | Review? added |
|---|
comment:3 Changed 15 years ago by
comment:4 Changed 15 years ago by
| Keywords: | Review- added; Review? removed |
|---|
Nice catch, and it works, but could you please use:
range.getCommonAncestor();
instead of
range.getBoundaryNodes().startNode;
when range is collapsed, actually they're the same for this case, but we're indenting to deprecate 'getBoundaryNodes'.
Changed 15 years ago by
| Attachment: | 3650_2.patch added |
|---|
comment:5 Changed 15 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:6 Changed 15 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:7 Changed 15 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [3623].
Click here for more info about our SVN system.
Note: See
TracTickets for help on using
tickets.
To get correct results when reviewing, you need to apply the patch to #3656 as well.