'Select All' result in content change

[Garry Yao]

Reproducing Procedures

1. Open the replace by class example page in FF with the following content;

   <ul><li>item</li></ul>
   

2. Click on 'Select All' button, after this step, the selection now is actually as:

   ^<ul><li>item</li></ul>^
   

   • Expected Result: The document content remain unchanged.
   • Actual Result: There's an paragraph established before the list:

     <p>
     	<br />
     </p>
     <ul>
     	<li>
     		item</li>
     </ul>
     

[Garry Yao]

Regression bug of [3549], adding the 'last path element is not block also' condition.

[Garry Yao]

Adding a new patch since it's possible in IE to have the following range where the previous patch doesn't covered:

<p>paragraph1</p>
^
<p></p>

[Garry Yao]

Replying to garry.yao:

Adding a new patch ...

After some investigation, fixing this issue will break other more general TC, so the original patch is preferred.

[Garry Yao]

Adding a new patch to support yet another interesting TC which has been found when investigating #3671, here the selected element become a fake, block-like element like "Page Break", we can distinguish it with function CKEDITOR.dom.element::isBlockBoundary, but I'm proposing to rename this function to avoid ambiguity.

[
<img ... / > //This is a 'block-like' fake element
]

[Garry Yao]

Another new patch with two updates;

1. use CKEDITOR.dom.selection::getSelectedElement instead of path.lastElement to check the selected element;
2. Free the padding block for table in IE to avoid DUP with the IE native fix.

[Garry Yao]

Two more updates:

1. Padding block for table is even not necessary for Webkit!
2. The correct checking should be attribute '_cke_bogus' on L140.

[Frederico Caldeira Knabben]

I think a simpler fix could be available. Actually, the fixing code needs to be execute exclusively over collapsed selections, so i should be enough to simply check for it.

[Garry Yao]

Fixed with [3656].