Opened 10 years ago

Closed 10 years ago

Last modified 4 years ago

#3706 closed Bug (fixed)

High Contrast - Color picker doesn't display colored options

Reported by: Damian Owned by: Tobiasz Cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: IBM Review+ Cc:

Description

When using high contrast mode, the color pickers lose their background color (which is normal behavior in HC), but there is no alternative way to "see" the colors. Users using HC should still be able to choose their desired color without needing to refer to textual tool-tips.

Attachments (3)

3706.patch (5.5 KB) - added by Tobiasz Cudnik 10 years ago.
3706_2.patch (631 bytes) - added by Tobiasz Cudnik 10 years ago.
Remove color buttons in HC mode.
3706_3.patch (608 bytes) - added by Tobiasz Cudnik 10 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 10 years ago by Frederico Caldeira Knabben

There is actually some misunderstanding here. The UI Color Picker is a "developer tool", not an "end user feature". It's there just to make it easy to find the color that best fits the developer needs.

For example, an Irish developer could play with a different range of green colors to precisely match the colors of her green Irish site. Then, the dialog will also give this developer the string to be used in config.js file to have her preferred color applied to the editor.

I'm leaving this ticket opened because we could add a note into the UI color sample to make it evident that this is just a developer tool.

As a final remark, there is no way to make this thing work in HC anyway.

comment:2 Changed 10 years ago by Damian

I have probably used the wrong terminology here. By color picker I mean the two color buttons on the toolbar: Font Color and Background Color.

comment:3 Changed 10 years ago by Tobiasz Cudnik

Owner: set to Tobiasz Cudnik
Status: newassigned

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3706.patch added

comment:4 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added

This patch adds color labels instead of colored backgrounds. This screenshot presents it in IE8.

What's missing is selecting color from actual range, but as ticket says "Users using HC should still be able to choose their desired color without needing to refer to textual tool-tips.", which is right now possible after applying the patch.

I would prefer to move above case to new ticket if it's necessary.

comment:5 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

There is a usability fact here. In HC, colors are disabled. It means that, even if a user applies color to text, s/he is not able to see the applied color. So, that user is not actually able to properly apply colors.

In that case, it's senseless having color features. As we're able to detect HC, we could therefore disable the color buttons, instead of introducing code overhead.

comment:6 in reply to:  5 Changed 10 years ago by Tobiasz Cudnik

Replying to fredck:

In that case, it's senseless having color features. As we're able to detect HC, we could therefore disable the color buttons, instead of introducing code overhead.

So should this issue be marked as wontfix and new one named "Disable colorbuttons in HC mode" be created ?

comment:7 Changed 10 years ago by Tobiasz Cudnik

Keywords: Pending added

comment:8 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Pending removed

That's ok to have it handled in this ticket for this specific case. The final fix can take other ways, but it's quite related, bringing the issue to a resolution.

comment:9 Changed 10 years ago by Damian

What Fred said makes sense, but we don't want to remove functionality from users when they move to HC mode, so if the features are disabled during HC, I would suggest that this be configurable.

Tobiasz's solution is good and meets the requirement of the defect.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3706_2.patch added

Remove color buttons in HC mode.

comment:10 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

New patch removes color buttons in HC mode.

I'm proposing splitting previous patch into support for HC in panels, which IMHO is needed in core. Rest is one markup change and css sheet which styles both panel and inner table.

comment:11 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review- added; Review? removed

The fix is ok, but please use CKEDITOR.env.hc for the HC check.

Changed 10 years ago by Tobiasz Cudnik

Attachment: 3706_3.patch added

comment:12 Changed 10 years ago by Tobiasz Cudnik

Keywords: Review? added; Review- removed

comment:13 Changed 10 years ago by Frederico Caldeira Knabben

Keywords: Review+ added; Review? removed

comment:14 Changed 10 years ago by Tobiasz Cudnik

Resolution: fixed
Status: assignedclosed

Fixed with [3687].

comment:15 Changed 4 years ago by Arugula

Hello, as a visually disabled person who uses black screen setups (and this the High contrast mode of Ckeditor), I DEFINITELY DON'T agree with penalizing me or other disabled people by removing needed functions!! It has been causing a lot of havoc for me!!! Can can we get a patch for this? Or show me where in the code we can fix this? I use dark screens [high contrast], but I also need the access to color buttons at times, for highlighting, etc, in my documents. I doubt anyone would want the buttons removed, but if so, Ckeditor is already configurable to remove any buttons. But now, how do I get the buttons back? :( Thanks for your help.

comment:16 Changed 4 years ago by Frederico Caldeira Knabben

@Arugula, thanks for your input on this. End user opinions and suggestions are gold for us ;)

This comment doesn't mean that we're intended to work on this immediately, but in the other hand we could at leat work to design a feasible solution for the future.

I've opened a new ticket for it, so please let's keep the discussion there: #13308.

Please note that there is no intent to penalize anyone with our approach. The point is that we found a technical limitation that we were not able to overcome and therefore we were simply unable to propose this feature.

I would appreciate your comments on that ticket especially if you could suggest, in a technical point of view, a way to overcome the main problem we have, which is the impossibility to show applied color in the editor contents.

Thanks!

comment:17 Changed 4 years ago by Piotrek Koszuliński

Just to clarify - @Argula reported #13294 where we discuss the possible solutions.

Note: See TracTickets for help on using tickets.
© 2003 – 2019 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy